-
Notifications
You must be signed in to change notification settings - Fork 1
SA-240_Refactor_LabelAccuracy_Class #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
marklondon999
wants to merge
62
commits into
main
Choose a base branch
from
SA-240_Refactor_LabelAccuracy_Class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unts matched and unmatched
…iscard failed duplicates
…lean to coder_alignment.py
…a_for_analysis.py to allow full end to end run
…ONSdigital/survey-assist-utils into SA-240_Refactor_LabelAccuracy_Class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Pull Request Template
I want to refactor the
LabelAccuracyclass by subdividing its responsibilities into distinct componentsso that the codebase is easier to maintain, test, and extend for future evaluation workflows.
Description:
The current
LabelAccuracyclass handles multiple responsibilities including data preprocessing, validation, accuracy computation, and visualisation.This refactor will involve breaking the class into smaller, purpose-specific modules or methods, such as:
Preprocessing: Handling input formatting, missing values, and column setup.
Accuracy Evaluation: Computing full and 2-digit match accuracy, Jaccard similarity, etc.
Visualisation: Generating plots, heatmaps, and summary displays.
Acceptance Criteria:
[ ]
LabelAccuracyis refactored into clearly defined subcomponents or methods.[ ] Each component has a single, well-defined responsibility.
[ ] Unit tests are updated or added for each new component.
[ ] No change in output or evaluation results from the original implementation.
[ ] Code is peer reviewed and merged.
✅ Checklist
terraform fmt&terraform validate)🔍 How to Test