Skip to content

fix(UBNetworkAccessManager): Use atomic_int instead of volatile #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(UBNetworkAccessManager): Use atomic_int instead of volatile #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/network/UBNetworkAccessManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#ifndef UBNETWORKACCESSMANAGER_H
#define UBNETWORKACCESSMANAGER_H

#include <atomic>
#include <QtNetwork>

class UBNetworkAccessManager : public QNetworkAccessManager
Expand All @@ -50,7 +51,7 @@ class UBNetworkAccessManager : public QNetworkAccessManager

static UBNetworkAccessManager *sNetworkAccessManager;

volatile int mProxyAuthenticationCount;
std::atomic_int mProxyAuthenticationCount;

private slots:
void authenticationRequired(QNetworkReply *reply, QAuthenticator *auth);
Expand Down