Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 4, 2025

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

<?

$v = '1';

$bug = match ($v) {
	1 => true,
	default => false
};
var_dump($bug); #false

$fix = match ((int) $v) {
	1 => true,
	default => false
};
var_dump($fix); #true

switch ($v) {
	case 1:
		$old = true;
		break;
	default:
		$old = false;
}
var_dump($old); #true

Copilot AI review requested due to automatic review settings October 4, 2025 00:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the email queue recipient type handling to properly cast the type parameter as an integer before the match statement. This fixes a type comparison issue where string values would not match the expected integer constants.

  • Adds explicit integer casting to the $type variable in the match statement
  • Ensures proper type matching between the recipient type and the EMAIL_TYPE_* constants

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Oct 4, 2025
@sreichel sreichel added the bug label Oct 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Test Results

811 tests   800 ✅  7s ⏱️
181 suites   11 💤
  1 files      0 ❌

Results for commit f96f90f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Test Results

811 tests   800 ✅  7s ⏱️
181 suites   11 💤
  1 files      0 ❌

Results for commit f96f90f.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2025

@kiatng kiatng merged commit 62376b2 into main Oct 4, 2025
43 checks passed
@sreichel sreichel deleted the fix/4932 branch October 4, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Component: Core Relates to Mage_Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BCC via email queue does send as to

4 participants