Fix HTML structure in shipment tracking email template #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Sales
Copilot finished reviewing on behalf of
loekvangool
November 20, 2025 15:58
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an HTML structure bug in the shipment tracking email template for the RWD theme. The issue caused malformed HTML output when a shipment had multiple tracking items.
Key Changes
- Fixed incorrect
<tbody>tag to<tr>inside the tracking items loop in the RWD shipment tracking email template
|
addison74
approved these changes
Nov 21, 2025
kiatng
approved these changes
Nov 21, 2025
Contributor
|
just want to point out that now the tbody tag is closed, but not opened 
|
Contributor
It is opened on L24? |
Contributor
|
oh my bad! I had checked and obviously misread, checking app/design/frontend/rwd/default/template/email/order/shipment/track.phtml it looks correct 
seeing the removal of the "tbody" tag, in this PR, got me confused. sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)