-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Bump ERC-4337 entrypoint to version 0.9 #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 107abe7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces support for ERC4337 entrypoint version 0.9 across the OpenZeppelin Solidity library. A new constant Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-10-15T02:52:05.027ZApplied to files:
📚 Learning: 2025-08-29T13:16:08.640ZApplied to files:
📚 Learning: 2025-09-04T09:13:21.278ZApplied to files:
📚 Learning: 2025-09-04T09:13:21.278ZApplied to files:
🧬 Code graph analysis (14)test/account/AccountMultiSignerWeighted.test.js (11)
test/account/extensions/AccountERC7579.test.js (11)
test/account/Account.test.js (11)
test/account/AccountMultiSigner.test.js (11)
test/account/extensions/AccountERC7579.behavior.js (2)
test/account/AccountWebAuthn.test.js (11)
test/account/extensions/AccountERC7579Hooked.test.js (11)
test/account/Account.behavior.js (1)
test/account/AccountERC7913.test.js (11)
test/account/AccountRSA.test.js (11)
test/account/AccountERC7702.test.js (11)
test/account/examples/AccountERC7702WithModulesMock.test.js (11)
test/account/AccountECDSA.test.js (11)
test/account/AccountP256.test.js (11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (24)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
| await expect(predeploy.entrypoint.v08.getNonce(this.mock.target, 0)).to.eventually.equal(0); | ||
| await expect(predeploy.entrypoint.v08.handleOps([operation.packed], this.beneficiary)) | ||
| .to.emit(predeploy.entrypoint.v08, 'AccountDeployed') | ||
| await expect(predeploy.entrypoint.v09.getNonce(this.mock.target, 0)).to.eventually.equal(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be great get something defined at project level like entrypoint.default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can think of a way to add aliases to hardhat-exposed for a next version.
I'd call it entrypoint.latest and not entrypoint.default
PR Checklist
npx changeset add)