Skip to content

Conversation

@andrewshab3
Copy link

@andrewshab3 andrewshab3 commented Dec 1, 2025

Fixes #????

Hello! I found a typo in ERC1155Supply.sol and fixed it
tokens in with -> tokens with

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@andrewshab3 andrewshab3 requested a review from a team as a code owner December 1, 2025 15:33
@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: 267e58e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the base branch from master to typo-fixes December 1, 2025 15:35
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

This pull request corrects a grammar error in a documentation comment within the ERC1155Supply contract. The phrase "Total value of tokens in with a given id." is modified to "Total value of tokens with a given id." by removing the redundant word "in". This is a documentation-only change with no impact on code functionality or control flow.

Possibly related PRs

Suggested labels

ignore-changeset, typo

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: fix typo' is vague and generic, using non-descriptive language that doesn't specify which typo was fixed or which file was affected. Improve the title to be more specific, e.g., 'fix: remove redundant word in ERC1155Supply documentation' or 'fix: correct grammar in ERC1155Supply natspec comment'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, clearly stating the typo fix ('tokens in with -> tokens with') and identifying the affected file (ERC1155Supply.sol).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bacb570 and a440f27.

📒 Files selected for processing (1)
  • contracts/token/ERC1155/extensions/ERC1155Supply.sol (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
  • GitHub Check: halmos
  • GitHub Check: tests-foundry
  • GitHub Check: tests-upgradeable
  • GitHub Check: coverage
  • GitHub Check: slither
  • GitHub Check: tests
🔇 Additional comments (1)
contracts/token/ERC1155/extensions/ERC1155Supply.sol (1)

29-29: Grammar correction is accurate.

The removal of the redundant "in" improves the documentation comment. "Total value of tokens with a given id." is now grammatically correct and clearly describes the function's purpose.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx
Copy link
Collaborator

Amxx commented Dec 1, 2025

Already covered by #5959

@Amxx Amxx closed this Dec 1, 2025
@andrewshab3
Copy link
Author

Already covered by #5959

Oh sorry, should i check typos from typos-fixes branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants