Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Oct 31, 2025

Overview

allow to track a reported error on Sentry

we can do search the uuid on Sentry

errorId:error-uuid

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji requested review from Copilot, jerader and ncdiehl11 October 31, 2025 20:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error tracking in the Protocol Designer by adding the error UUID as a Sentry tag, making it easier to search for specific error reports using the errorId:error-uuid syntax in Sentry's search interface.

Key Changes:

  • Modified the Sentry captureException call to include errorId as both an extra field and a tag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@koji koji changed the base branch from edge to chore_release-pd-8.6.3 October 31, 2025 20:28
@koji koji marked this pull request as ready for review October 31, 2025 20:28
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.57%. Comparing base (82ec056) to head (5d49a6b).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.6.3   #20001      +/-   ##
==========================================================
- Coverage                   57.99%   55.57%   -2.43%     
==========================================================
  Files                        3413     3557     +144     
  Lines                      283940   301173   +17233     
  Branches                    39368    40279     +911     
==========================================================
+ Hits                       164671   167372    +2701     
- Misses                     118996   133527   +14531     
- Partials                      273      274       +1     
Flag Coverage Δ
protocol-designer 18.71% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gner/src/resources/ProtocolDesignerAppFallback.tsx 84.90% <100.00%> (+1.23%) ⬆️

... and 779 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. From this part of the Sentry docs, it sounds like tags are supposed to help with filtering and aggregating error instances together. If every instance of an error is tagged with its own random unique ID, how does that help?

@jerader
Copy link
Collaborator

jerader commented Nov 3, 2025

i have the same question as Max 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants