Skip to content

Conversation

@emilyburghardt
Copy link
Collaborator

@emilyburghardt emilyburghardt commented Nov 4, 2025

Overview

Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources.

picking up on Monday 11/10 with the following:

  • Rework Heater-Shaker to include two separate heating and shaking sections
  • Replace time section(s) with create_timer
  • Work on code samples
  • Pick up TC at block control

Test Plan and Hands on Testing

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

  • Indicate the level of attention this PR needs.
  • Provide context to guide reviewers.
  • Discuss trade-offs, coupling, and side effects.
  • Look for the possibility, even if you think it's small, that your change may affect some other part of the system.
    • For instance, changing return tip behavior may also change the behavior of labware calibration.
  • How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions?
  • Especially in high risk PRs, explain how you know your testing is enough.

@ecormany ecormany removed the mkdocs label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.92%. Comparing base (ba8aae6) to head (5df10f2).
⚠️ Report is 1 commits behind head on chore_release-8.8.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-8.8.0   #20027   +/-   ##
====================================================
  Coverage                25.92%   25.92%           
====================================================
  Files                     3539     3539           
  Lines                   295387   295387           
  Branches                 42047    42047           
====================================================
  Hits                     76573    76573           
  Misses                  218790   218790           
  Partials                    24       24           
Flag Coverage Δ
step-generation 5.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants