Skip to content

Conversation

@jerader
Copy link
Collaborator

@jerader jerader commented Nov 6, 2025

…ck icon

closes AUTH-2445

Overview

fixes a bug with showing duplicate stacking icons and then has to special-case the tiprack lid svg stacking icon since it shows up in the wrong spot due to the tprack lid svg bug

Screenshot 2025-11-06 at 09 19 04

Test Plan and Hands on Testing

see that there is no double stacking icon on a tiprack with a tiprack lid

Changelog

show the deck labware stacking icon only once when the deck map is zoomed out

Risk assessment

low

@jerader jerader requested review from koji and ncdiehl11 November 6, 2025 17:19
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.31%. Comparing base (fedc8ad) to head (8fd5aa7).

Files with missing lines Patch % Lines
.../src/pages/Designer/DeckSetup/DeckSetupDetails.tsx 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20060      +/-   ##
==========================================
- Coverage   25.31%   25.31%   -0.01%     
==========================================
  Files        3549     3549              
  Lines      296827   296834       +7     
  Branches    42170    42170              
==========================================
  Hits        75145    75145              
- Misses     221664   221671       +7     
  Partials       18       18              
Flag Coverage Δ
protocol-designer 19.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/pages/Designer/DeckSetup/DeckSetupDetails.tsx 0.35% <0.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants