Skip to content

Conversation

@CaseyBatten
Copy link
Contributor

Overview

Originally the live stream default file we copied if the live stream configuration didn't exist had the camera set to "NONE". Now, thanks to some oe-core changes here that is no longer the case. For any robot that made a copy of this file with out-of date data we should clean up the mutable configuration file.

Test Plan and Hands on Testing

Run this on a robot with a mutable live stream configuraiton file under the /data folder and ensure it writes with the new default.

Changelog

Review requests

Do we want to do this, or do we want any robot that had alphas to just delete their mutable file? We won't have this kind of problem on any new robots in the field that are going to 8.8 for the first time, only bots that ran alphas.

Risk assessment

Low

@CaseyBatten CaseyBatten requested a review from mjhuff November 7, 2025 18:50
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go about it. Very robust

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.23%. Comparing base (8ecd356) to head (43ff4d6).
⚠️ Report is 3 commits behind head on chore_release-8.8.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.8.0   #20077      +/-   ##
=======================================================
- Coverage                26.50%   25.23%   -1.27%     
=======================================================
  Files                     3550     3550              
  Lines                   298225   298222       -3     
  Branches                 42864    42864              
=======================================================
- Hits                     79030    75248    -3782     
- Misses                  219171   222956    +3785     
+ Partials                    24       18       -6     
Flag Coverage Δ
app 0.92% <ø> (-2.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for walking me through this. Makes sense to me!

@CaseyBatten CaseyBatten merged commit a61512e into chore_release-8.8.0 Nov 7, 2025
71 checks passed
@CaseyBatten CaseyBatten deleted the live_stream_camera_default_migrate branch November 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants