-
Notifications
You must be signed in to change notification settings - Fork 186
chore(step-generation): state update for FlexStacker in getNextRobotStateAndWarningsSingleCommand #20120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
chore(step-generation): state update for FlexStacker in getNextRobotStateAndWarningsSingleCommand #20120
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #20120 +/- ##
===========================================
- Coverage 57.09% 25.30% -31.79%
===========================================
Files 3541 3571 +30
Lines 295724 301363 +5639
Branches 42198 43018 +820
===========================================
- Hits 168847 76265 -92582
- Misses 126596 225075 +98479
+ Partials 281 23 -258
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| } | ||
| const FLEX_STACKER_INITIAL_STATE: FlexStackerModuleState = { | ||
| type: FLEX_STACKER_MODULE_TYPE, | ||
| latchOpen: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
| export interface FlexStackerModuleState { | ||
| type: typeof FLEX_STACKER_MODULE_TYPE | ||
| // TODO: extend this state | ||
| latchOpen: boolean | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
| 'Cannot store labware bc there is no space in the stacker' | ||
| ) | ||
| } | ||
| // get labware id on module from the move labware command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix for this pr?
Overview
closes https://opentrons.atlassian.net/browse/EXEC-2018.
first part of robot state update for the flex stacker.
updating robot state based on flex stacker commandCreate
Test Plan and Hands on Testing
Its tricky to test this bc the flex stacker form update is not wired yet but I wrote unit tests to back up my changes.
Changelog
stackerStateUpdatesto parse the commands as state updates.set_stored_labwarepython command to PythonFileUtils.Risk assessment
low. should just update robot state but nothing is referencing it at the moment.