Skip to content

Conversation

@TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Nov 12, 2025

Overview

closes https://opentrons.atlassian.net/browse/EXEC-2018.
first part of robot state update for the flex stacker.
updating robot state based on flex stacker commandCreate

Test Plan and Hands on Testing

Its tricky to test this bc the flex stacker form update is not wired yet but I wrote unit tests to back up my changes.

Changelog

  1. added stackerStateUpdates to parse the commands as state updates.
  2. added set_stored_labware python command to PythonFileUtils.
  3. baseline for form steps state update.

Risk assessment

low. should just update robot state but nothing is referencing it at the moment.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 62.97376% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.30%. Comparing base (64c7314) to head (e134190).
⚠️ Report is 127 commits behind head on edge.

Files with missing lines Patch % Lines
...red-data/js/helpers/getFlexStackerHardwareProps.ts 7.69% 60 Missing ⚠️
...neration/src/getNextRobotStateAndWarnings/index.ts 10.71% 25 Missing ⚠️
...src/getNextRobotStateAndWarnings/stackerUpdates.ts 86.07% 22 Missing ⚠️
shared-data/js/helpers/symbolicPositionHelpers.ts 20.00% 8 Missing ⚠️
step-generation/src/robotStateSelectors.ts 38.46% 8 Missing ⚠️
step-generation/src/utils/pythonFileUtils.ts 80.95% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #20120       +/-   ##
===========================================
- Coverage   57.09%   25.30%   -31.79%     
===========================================
  Files        3541     3571       +30     
  Lines      295724   301363     +5639     
  Branches    42198    43018      +820     
===========================================
- Hits       168847    76265    -92582     
- Misses     126596   225075    +98479     
+ Partials      281       23      -258     
Flag Coverage Δ
protocol-designer 19.13% <8.52%> (+0.12%) ⬆️
step-generation 5.58% <60.64%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rotocol-designer/src/step-forms/selectors/index.ts 33.48% <100.00%> (+1.15%) ⬆️
protocol-designer/src/step-forms/types.ts 100.00% <ø> (ø)
shared-data/js/fixtures.ts 46.94% <ø> (-27.62%) ⬇️
shared-data/js/helpers/index.ts 59.59% <ø> (+9.59%) ⬆️
...ion/src/commandCreators/atomic/flexStackerEmpty.ts 100.00% <100.00%> (ø)
step-generation/src/errorCreators.ts 70.50% <100.00%> (+0.59%) ⬆️
step-generation/src/types.ts 100.00% <ø> (ø)
step-generation/src/utils/pythonFileUtils.ts 93.58% <80.95%> (+6.01%) ⬆️
shared-data/js/helpers/symbolicPositionHelpers.ts 77.14% <20.00%> (-22.86%) ⬇️
step-generation/src/robotStateSelectors.ts 69.26% <38.46%> (-2.12%) ⬇️
... and 3 more

... and 1930 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
const FLEX_STACKER_INITIAL_STATE: FlexStackerModuleState = {
type: FLEX_STACKER_MODULE_TYPE,
latchOpen: null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

export interface FlexStackerModuleState {
type: typeof FLEX_STACKER_MODULE_TYPE
// TODO: extend this state
latchOpen: boolean | null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

'Cannot store labware bc there is no space in the stacker'
)
}
// get labware id on module from the move labware command
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix for this pr?

@TamarZanzouri TamarZanzouri changed the title Exec 2018 robot state and timeline for stacker chore(step-generation): state update for FlexStacker in getNextRobotStateAndWarningsSingleCommand Nov 14, 2025
@TamarZanzouri TamarZanzouri marked this pull request as ready for review November 14, 2025 20:48
@TamarZanzouri TamarZanzouri requested a review from a team as a code owner November 14, 2025 20:48
@TamarZanzouri TamarZanzouri requested a review from mjhuff November 14, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants