Skip to content

Conversation

@rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Nov 13, 2025

Overview

Fix casing and font for devices page, removed robot name from deck configuration header.

Test Plan and Hands on Testing

smoke tested

Screenshot 2025-11-13 at 10 39 58 AM Screenshot 2025-11-13 at 10 40 20 AM Screenshot 2025-11-13 at 11 17 03 AM Screenshot 2025-11-13 at 12 46 12 PM

Risk assessment

low

Closes RQA-4857
Closes RQA-4858
Closes RQA-4828
Closes RQA-4835

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.03%. Comparing base (27e5059) to head (ae355e3).
⚠️ Report is 1 commits behind head on chore_release-8.8.0.

Files with missing lines Patch % Lines
...rganisms/Desktop/Devices/InstrumentsAndModules.tsx 0.00% 3 Missing ⚠️
...c/organisms/Desktop/Devices/RecentProtocolRuns.tsx 0.00% 3 Missing ⚠️
...organisms/DeviceDetailsDeckConfiguration/index.tsx 0.00% 3 Missing ⚠️
...ms/ODD/CameraSettings/UsagePreferencesSettings.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.8.0   #20139      +/-   ##
=======================================================
+ Coverage                24.09%   25.03%   +0.93%     
=======================================================
  Files                     3541     3541              
  Lines                   295667   295741      +74     
  Branches                 42623    42623              
=======================================================
+ Hits                     71250    74026    +2776     
+ Misses                  224395   221697    -2698     
+ Partials                    22       18       -4     
Flag Coverage Δ
app 2.08% <0.00%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ms/ODD/CameraSettings/UsagePreferencesSettings.tsx 0.00% <0.00%> (ø)
...rganisms/Desktop/Devices/InstrumentsAndModules.tsx 0.00% <0.00%> (ø)
...c/organisms/Desktop/Devices/RecentProtocolRuns.tsx 0.00% <0.00%> (ø)
...organisms/DeviceDetailsDeckConfiguration/index.tsx 0.00% <0.00%> (ø)

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rclarke0 rclarke0 requested a review from a team as a code owner November 13, 2025 16:27
@rclarke0 rclarke0 requested a review from mjhuff November 13, 2025 17:23
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attaching the pictures, it's very helpful. Changes requested for the InflineNotification refactors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this component is used in a ton of call sites, while this fixes the problem outlined in the DQA ticket, it breaks functionality in every other place we use this component.

To fix the issue in this spot, we need to update the translation string that uses this component not to use a period. Yes, it's unideal, but the alternative is correcting like 50+ other places, and we don't have the capacity to do that right now.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rclarke0 rclarke0 merged commit 4d75ef9 into chore_release-8.8.0 Nov 13, 2025
37 of 38 checks passed
@rclarke0 rclarke0 deleted the RQA-4857 branch November 17, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants