-
Notifications
You must be signed in to change notification settings - Fork 186
fix(app): casing and font for device page #20139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.8.0 #20139 +/- ##
=======================================================
+ Coverage 24.09% 25.03% +0.93%
=======================================================
Files 3541 3541
Lines 295667 295741 +74
Branches 42623 42623
=======================================================
+ Hits 71250 74026 +2776
+ Misses 224395 221697 -2698
+ Partials 22 18 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mjhuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for attaching the pictures, it's very helpful. Changes requested for the InflineNotification refactors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this component is used in a ton of call sites, while this fixes the problem outlined in the DQA ticket, it breaks functionality in every other place we use this component.
To fix the issue in this spot, we need to update the translation string that uses this component not to use a period. Yes, it's unideal, but the alternative is correcting like 50+ other places, and we don't have the capacity to do that right now.
mjhuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Overview
Fix casing and font for devices page, removed robot name from deck configuration header.
Test Plan and Hands on Testing
smoke tested
Risk assessment
low
Closes RQA-4857
Closes RQA-4858
Closes RQA-4828
Closes RQA-4835