-
Notifications
You must be signed in to change notification settings - Fork 186
Merge back 'chore_release-8.8.0' into 'edge' #20140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Overview new motion planning from dynamic pipetting can trigger a zero move length error in a new spot so that call needs to be added into the try/except portion.
The old opentrons deploy actions would build the distributables as well as deploy them; now that we're using the pypi-maintained deploy actions, we need to build them explicitly (we can't use the ones we already built because that happened in a different job aka vm).
This reverts commit 7e313a3.
# Overview The JavaScript console for the ODD was filling up with log messages of: ``` [app//opt/opentrons-app/resources/app.asar/ui/assets/index-XXX.js] debug: Received action from main via IPC -------------------------------------------------- ▶ Object ``` which is not very helpful. This PR is a small tweak to inline the action into the log message so that you can see it without clicking on `▶ Object`, decluttering the console. #### Before: <img width="1176" height="586" alt="image" src="https://github.com/user-attachments/assets/fb503f36-337a-4031-a026-2067db8df67f"/> #### After: <img width="1166" height="432" alt="image" src="https://github.com/user-attachments/assets/ec79376f-c692-4b1f-a9b4-b7bfcb7c7fab"/> ## Test Plan and Hands on Testing Built the ODD and deployed it to AuthorshipPVT for hands-on testing. ## Risk assessment Low.
# Overview Specify Camera type based on robot type on peripherals card ## Test Plan and Hands on Testing Smoke tested <img width="390" height="172" alt="Screenshot 2025-11-10 at 11 54 37 AM" src="https://github.com/user-attachments/assets/8b4368b2-7776-402c-8e68-38b8557e339b" /> <img width="341" height="166" alt="Screenshot 2025-11-10 at 11 55 18 AM" src="https://github.com/user-attachments/assets/8b09ed20-0d1d-42cd-bee1-a415b14005c2" /> ## Changelog Conditionally displays camera type based on robot, added in camera icon ## Risk assessment low closes EXEC-2040
…20122) # Overview Plunger moves in the negative direction were broken because the unit vector is negative and the plan motion function expects speed to always be positive.
The old opentrons deploy actions would build the distributables as well as deploy them; now that we're using the pypi-maintained deploy actions, we need to build them explicitly (we can't use the ones we already built because that happened in a different job aka vm). ## Testing Unfortunately there's not much we can do here, but this is already broken and this is pretty straightforward.
Covers RQA-4848 Enforce that calls to the capture_image command must provide filter params with percentage values
Covers RQA-4852 Spacebars are once again allowed in image file names
…ure (#20126) # Overview Copy changes to livestream window to include robot name and changed error image capture header ## Test Plan and Hands on Testing smoke tested on app and odd <img width="919" height="674" alt="Screenshot 2025-11-13 at 9 58 24 AM" src="https://github.com/user-attachments/assets/76a4eeb7-d84d-493d-ae9c-4b40a4ad4ab5" /> <img width="968" height="417" alt="Screenshot 2025-11-12 at 1 42 14 PM" src="https://github.com/user-attachments/assets/d40eeefa-b638-4803-96a7-119f9488f728" /> <img width="496" height="436" alt="Screenshot 2025-11-12 at 1 46 03 PM" src="https://github.com/user-attachments/assets/2ecd2f03-9221-4a05-b801-9f6f0a77c29b" /> ## Risk assessment low Closes EXEC-2051 Closes EXEC-2052 Closes RQA-4850
# Overview Previously, the `Labware.set_offset()` function claimed that ``` The offset is an x, y, z vector in deck coordinates (see :ref:`protocol-api-deck-coords`). ``` This is misleading because a deck coordinate of `(0, 0, 0)` means the front left corner of the deck, but `set_offset(0, 0, 0)` would **not** put the labware on the front left corner of the deck. Then there's also the `Labware.calibrated_offset` property, which **does** return deck coordinates, but is not documented as doing so. This PR swaps the deck coordinates comment from `Labware.set_offset()` to `Labware.calibrated_offset`. ## Test Plan and Hands on Testing No change to functionality at all, just a docstring change. ## Risk assessment Low.
Resolved conflicts: - app/src/organisms/ODD/QuickTransferFlow/utils/createQuickTransferFile.ts
422de6d to
caf1a07
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #20140 +/- ##
==========================================
+ Coverage 24.29% 25.88% +1.59%
==========================================
Files 3565 3565
Lines 297380 297402 +22
Branches 42131 42046 -85
==========================================
+ Hits 72247 76995 +4748
+ Misses 225111 220388 -4723
+ Partials 22 19 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Resolved conflicts: - app/src/organisms/ODD/QuickTransferFlow/utils/createQuickTransferFile.ts Edited: - app/src/organisms/Desktop/Devices/Peripherals/CameraCard.tsx
caf1a07 to
820fab0
Compare
rclarke0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! lgtm
@jerader Your change to delete QT JSON generation created a bit of a merge conflict, but it should be fine now :)
@rclarke0 I had to edit your
CameraCard.tsxafter @mjhuff's PR #20089 renamedphoto-camera->camera.