fix(api): fix error propagation in dynamic pipetting. #20143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e immediatly fails the run and throws a position unknown error.
sfoster1
approved these changes
Nov 13, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Looks good if we're okay to put this in after code freeze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously:
When overpressures happened, they were not updating the machine position and would then fail to recover.
Stalls were not caught at all and would create a Motion Failed error.
Now
Updates automatically require machine position when an overpressure occurs during a dynamic pipetting action.
Overpressures and Stalls are properly caught and reported out of the protocol engine command.
Tested this on alpha 5 and both types of errors now correctly trigger error recovery.