-
Notifications
You must be signed in to change notification settings - Fork 186
docs: camera-enablement #20175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: camera-enablement #20175
Conversation
I need to save before something bad happens
Struggling with images.
Includes camera enablement
- settings.md - robot.md
Removing this weird thing on line 166
Shorter list, excludes camera prefs.
ecormany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this draft to avoid the issues with the settings screen; we'll pick those up later.
Content is good, but I think it could be reshuffled a bit to best fit in with the existing structure of the two modified pages.
| !!! note | ||
| If you need to maintain a comprehensive record of all runs performed on your Flex, you must use the **Download run log** feature to save this information to your computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange that this note breaks up the list here. Either:
- Put it after the entire list (most like previous revision).
- Put it inside the
Download run logbullet (indented so it's contained in that list item).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is maybe for the other PRs that got merged together, not for the camera PR?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## docs-8.8 #20175 +/- ##
============================================
+ Coverage 25.88% 25.92% +0.03%
============================================
Files 3565 3577 +12
Lines 297402 299568 +2166
Branches 42046 42667 +621
============================================
+ Hits 76995 77672 +677
- Misses 220388 221877 +1489
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mjhuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commenting that all of this is accurate from a SW POV. Thank you!
e3a115f to
eae7567
Compare
eae7567 to
d448204
Compare
I need to save before something bad happens
Struggling with images.
Includes camera enablement
- settings.md - robot.md
Removing this weird thing on line 166
Shorter list, excludes camera prefs.
d448204 to
d492f32
Compare
…/opentrons into docs-camera-enablement
Co-authored-by: Ed Cormany <[email protected]>
- Change camera specs to "2-megapixel" - Revert to original ODD image in Robot Settings - Move some camera details text to system description.
Overview
Updates the Flex manual with basic information about the built-in camera.
Sandbox:
Opentrons App: https://sandbox.docs.opentrons.com/docs-camera-enablement/flex/opentrons-app/
(see also a bullet in the "Recent Protocol Runs" section that follows. Explains downloading images.)
Touchscreen > robot settings: https://sandbox.docs.opentrons.com/docs-camera-enablement/flex/touchscreen/settings/
System Description > Frame and enclosure: https://sandbox.docs.opentrons.com/docs-camera-enablement/flex/system-description/robot/
RTC-884
Test Plan and Hands on Testing
Making sure images and links work.
Changelog
Opentrons App chapter: Modifies
opentrons-app.mdto include a new section about the camera. Additional changes (more camera features) will come with 8.9, so this first version is basic functionality.Touchscreen > Robot Settings: Modifies
settings.md. Updates the ODD image that shows all the settings. This istouchscreen-settings.png. No new text or text changes.System Description: Modifies
robot.md. In the "Frame and Enclosure" section, adds link to Opentrons App chapter to text in the sentence, "A 2.1-megapixel camera can photograph the deck and working area..."Review requests
The "Camera features and controls" section in the App chapter is the most significant change here. It introduces new information about the camera. This first camera release is limited, other features (e.g. shown in the Figma designs) aren't here and will be released later. Remember, this focuses on the very basic features and functions.
Risk assessment
Low but important. Want to give users enough to use the camera easily.