Skip to content

Conversation

@jwwojak
Copy link
Contributor

@jwwojak jwwojak commented Nov 17, 2025

Overview

Updates the Flex manual with basic information about the built-in camera.

Sandbox:

RTC-884

Test Plan and Hands on Testing

Making sure images and links work.

Changelog

Opentrons App chapter: Modifies opentrons-app.md to include a new section about the camera. Additional changes (more camera features) will come with 8.9, so this first version is basic functionality.

Touchscreen > Robot Settings: Modifies settings.md. Updates the ODD image that shows all the settings. This is touchscreen-settings.png. No new text or text changes.

System Description: Modifies robot.md. In the "Frame and Enclosure" section, adds link to Opentrons App chapter to text in the sentence, "A 2.1-megapixel camera can photograph the deck and working area..."

Review requests

The "Camera features and controls" section in the App chapter is the most significant change here. It introduces new information about the camera. This first camera release is limited, other features (e.g. shown in the Figma designs) aren't here and will be released later. Remember, this focuses on the very basic features and functions.

Risk assessment

Low but important. Want to give users enough to use the camera easily.

I need to save before something bad happens
Struggling with images.
Includes camera enablement
- settings.md
- robot.md
@ecormany ecormany changed the base branch from edge to docs-8.8 November 19, 2025 18:40
Shorter list, excludes camera prefs.
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this draft to avoid the issues with the settings screen; we'll pick those up later.

Content is good, but I think it could be reshuffled a bit to best fit in with the existing structure of the two modified pages.

Comment on lines 156 to 157
!!! note
If you need to maintain a comprehensive record of all runs performed on your Flex, you must use the **Download run log** feature to save this information to your computer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that this note breaks up the list here. Either:

  • Put it after the entire list (most like previous revision).
  • Put it inside the Download run log bullet (indented so it's contained in that list item).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe for the other PRs that got merged together, not for the camera PR?

@emilyburghardt emilyburghardt requested a review from a team as a code owner November 19, 2025 22:41
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 245 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.92%. Comparing base (820fab0) to head (e3a115f).
⚠️ Report is 46 commits behind head on docs-8.8.

Files with missing lines Patch % Lines
...w/QuickTransferAdvancedSettings/DisposalVolume.tsx 0.00% 45 Missing ⚠️
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 39 Missing ⚠️
.../Desktop/Devices/ProtocolRun/SetupCamera/index.tsx 0.00% 36 Missing ⚠️
...ms/ODD/ProtocolSetup/ProtocolSetupCamera/index.tsx 0.00% 34 Missing ⚠️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 0.00% 30 Missing ⚠️
...organisms/ODD/QuickTransferFlow/utils/pythonDef.ts 0.00% 20 Missing ⚠️
app-shell/src/ui.ts 0.00% 9 Missing ⚠️
...HeaderModalContainer/useRunHeaderModalContainer.ts 0.00% 8 Missing ⚠️
...s/Desktop/Devices/ProtocolRun/ProtocolRunSetup.tsx 0.00% 4 Missing ⚠️
app/src/pages/ODD/ProtocolSetup/index.tsx 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           docs-8.8   #20175      +/-   ##
============================================
+ Coverage     25.88%   25.92%   +0.03%     
============================================
  Files          3565     3577      +12     
  Lines        297402   299568    +2166     
  Branches      42046    42667     +621     
============================================
+ Hits          76995    77672     +677     
- Misses       220388   221877    +1489     
  Partials         19       19              
Flag Coverage Δ
protocol-designer 19.24% <2.85%> (+0.11%) ⬆️
step-generation 5.51% <12.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/hardware_control/motion_planning/move_manager.py 89.58% <ø> (ø)
...ration/src/commandCreators/compound/consolidate.ts 83.07% <100.00%> (+3.99%) ⬆️
...eration/src/commandCreators/compound/distribute.ts 80.09% <100.00%> (+3.70%) ⬆️
app-shell/src/secondary-windows/index.ts 0.00% <0.00%> (ø)
...ms/ODD/CameraSettings/UsagePreferencesSettings.tsx 0.00% <0.00%> (ø)
.../Desktop/LivestreamViewer/LivestreamInfoScreen.tsx 0.00% <0.00%> (ø)
...eneration/src/commandCreators/compound/transfer.ts 85.53% <91.66%> (+0.03%) ⬆️
app-shell-odd/src/ui.ts 0.00% <0.00%> (ø)
...rganisms/Desktop/Devices/InstrumentsAndModules.tsx 0.00% <0.00%> (ø)
...c/organisms/Desktop/Devices/RecentProtocolRuns.tsx 0.00% <0.00%> (ø)
... and 11 more

... and 81 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting that all of this is accurate from a SW POV. Thank you!

@ecormany ecormany force-pushed the docs-camera-enablement branch from e3a115f to eae7567 Compare November 20, 2025 15:05
@ecormany ecormany requested a review from a team as a code owner November 20, 2025 15:05
@ecormany ecormany requested review from TamarZanzouri and removed request for a team November 20, 2025 15:05
@ecormany ecormany force-pushed the docs-camera-enablement branch from eae7567 to d448204 Compare November 20, 2025 15:07
I need to save before something bad happens
Struggling with images.
@ecormany ecormany force-pushed the docs-camera-enablement branch from d448204 to d492f32 Compare November 20, 2025 15:08
jwwojak and others added 3 commits November 20, 2025 12:48
- Change camera specs to "2-megapixel"
- Revert to original ODD image in Robot Settings
- Move some camera details text to system description.
@jwwojak jwwojak merged commit aa23aa7 into docs-8.8 Nov 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants