Merge back 'chore_release-8.8.0' into 'chore_release-pd-8.7.0' #20223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art of QuickTransferSummaryState (#20212) # Overview This is a type-hinting change to tell TypeScript that the `aspirateState`/`dispenseState` in `retrieveLiquidClassValues.ts` is part of `QuickTransferSummaryState`. Without this, VS Code doesn't find this file when we're looking for places that touch `.disposalVolumeDispenseSettings`, wasting a lot of time for programmers trying to find what is setting that field. Adding this annotation also helps TypeScript catch typos. For example, if this file had accidentally misspelled the field as `disposalVolumeDispenseSettingsxx`, TypeScript would now complain about it. ## Test Plan and Hands on Testing Just run CI. ## Risk assessment Very low. No functional change whatsoever.
Correctly use `set_load_module` for StateUpdate when mapping 2.13 and below PAPI load module calls
Closes RQA-4807 To denote image capture on protocol error, the HTTP API uses the `errorRecoveryCameraEnabled` field except for `GET /camera`, in which case we use `errorRecoveryEnabled`. The JS code expects the shape of the camera settings to conform to the pattern elsewhere. To keep the HTTP API and the app consistent, let's update our one usage of `errorRecoveryEnabled` to `errorRecoveryCameraEnabled`. --------- Co-authored-by: Rhyann Clarke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess we're doing
chore_release-8.8.0->chore_release-pd-8.7.0->edgenow.