Skip to content

Add PublisherDomain table and migration script #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2025
Merged

Add PublisherDomain table and migration script #345

merged 6 commits into from
Nov 12, 2025

Conversation

@jwalterss
Copy link
Contributor

@jwalterss jwalterss commented Nov 12, 2025 •
edited
Loading

Goal

Add PublisherDomain table to curated-corpus database to track publisher names
associated with domain names.

  • Add PublisherDomain model to Prisma schema with fields: domainName (PK),
    publisher, createdAt, createdBy, updatedAt, updatedBy
  • Create migration that inserts 23 publisher domains from provided data
  • Migration only inserts domains that exist in ApprovedItem table (using WHERE
    EXISTS clause)
  • Export PublisherDomain type in database types

Implementation Decisions

  • Used domainName as primary key to ensure uniqueness per domain
  • Migration uses WHERE EXISTS to only insert domains that are actually used in
    ApprovedItem table
  • Set createdBy to 'migration' for seeded data
  • All standard audit fields included (createdAt, createdBy, updatedAt,
    updatedBy)

Deployment steps

  • Database migrations? Yes - migration file created and tested locally
  • Deployed to dev?
  • Secrets? No

References

JIRA ticket:

@jwalterss
Add PublisherDomain table and migration script
7f00282 
- Add PublisherDomain model to Prisma schema with fields: domainName (PK), publisher, createdAt, createdBy, updatedAt, updatedBy
- Create migration that inserts 23 publisher domains
- Migration only inserts domains that exist in ApprovedItem table
- Export PublisherDomain type in database types
@jwalterss jwalterss requested a review from a team as a code owner November 12, 2025 14:26
@jwalterss jwalterss requested a review from mmiermans November 12, 2025 14:31
@mmiermans
Include all domain names used on New Tab
624cfa4 
This is the full set of domains from the 'domain_business_metadata' table
that were ever used on a ScheduledItem or SectionItem.
@mmiermans
Fix comment on migration file
1058908
mmiermans
mmiermans previously approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment. Feel free to merge once that's addressed.

@jwalterss jwalterss merged commit 02e2275 into main Nov 12, 2025
14 checks passed
@jwalterss jwalterss deleted the HNT-1223-add-PublisherDomainTable branch November 12, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmiermans mmiermans mmiermans approved these changes

Assignees

No one assigned

Labels

curated-corpus-api-cdk-production/no-changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwalterss @mmiermans