Skip to content

chore: add cymbal to hobby docker #41841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −0
Open

chore: add cymbal to hobby docker #41841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41336db
chore: add cymbal to hobby docker
daibhin Nov 20, 2025
0976026
Update docker-compose.base.yml
daibhin Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docker-compose.base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,22 @@ services:
SKIP_READS: 'false'
FILTER_MODE: 'opt-out'

cymbal:
image: ghcr.io/posthog/posthog/cymbal:master
build:
context: rust/
args:
BIN: cymbal
restart: on-failure
Comment on lines +284 to +290
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: missing volume mount for GeoLite2 database. cymbal needs access to the MaxMind database file (see config.rs:136-137 and config.rs:174-182). the feature-flags service at line 302-303 includes volumes: - ./share:/share for this purpose. without this mount, MAXMIND_DB_PATH will point to a non-existent file

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docker-compose.base.yml
Line: 284:290

Comment:
**logic:** missing volume mount for GeoLite2 database. cymbal needs access to the MaxMind database file (see `config.rs:136-137` and `config.rs:174-182`). the `feature-flags` service at line 302-303 includes `volumes: - ./share:/share` for this purpose. without this mount, `MAXMIND_DB_PATH` will point to a non-existent file

How can I resolve this? If you propose a fix, please make it concise.

environment:
DATABASE_URL: 'postgres://posthog:posthog@db:5432/posthog'
KAFKA_HOSTS: 'kafka:9092'
Comment on lines +291 to +293
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: missing required environment variables for cymbal. Based on rust/cymbal/src/config.rs:71-141, cymbal requires:

  • REDIS_URL (used for caching, see line 139-140)
  • Object storage config: OBJECT_STORAGE_ENDPOINT, OBJECT_STORAGE_BUCKET, OBJECT_STORAGE_ACCESS_KEY_ID, OBJECT_STORAGE_SECRET_ACCESS_KEY, OBJECT_STORAGE_FORCE_PATH_STYLE (lines 71-87, used for storing symbol sets)
  • MAXMIND_DB_PATH for geolocation (line 136-137)

compare with the feature-flags service configuration at lines 304-322 which includes all these. without these, cymbal will fail to start or function correctly

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docker-compose.base.yml
Line: 291:293

Comment:
**logic:** missing required environment variables for cymbal. Based on `rust/cymbal/src/config.rs:71-141`, cymbal requires:
- `REDIS_URL` (used for caching, see line 139-140)
- Object storage config: `OBJECT_STORAGE_ENDPOINT`, `OBJECT_STORAGE_BUCKET`, `OBJECT_STORAGE_ACCESS_KEY_ID`, `OBJECT_STORAGE_SECRET_ACCESS_KEY`, `OBJECT_STORAGE_FORCE_PATH_STYLE` (lines 71-87, used for storing symbol sets)
- `MAXMIND_DB_PATH` for geolocation (line 136-137)

compare with the `feature-flags` service configuration at lines 304-322 which includes all these. without these, cymbal will fail to start or function correctly

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor Author

@daibhin daibhin Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this works yet because I tested a self-hosted deploy and cymbal threw these errors:

2025-11-20T17:27:57.179241Z ERROR librdkafka: librdkafka: FAIL [thrd:localhost:9092/bootstrap]: localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT)
2025-11-20T17:27:57.179292Z ERROR rdkafka::client: librdkafka: Global error: BrokerTransportFailure (Local: Broker transport failure): localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT)
2025-11-20T17:27:57.182469Z ERROR rdkafka::client: librdkafka: Global error: AllBrokersDown (Local: All broker connections are down): 1/1 brokers are down
2025-11-20T17:27:58.177420Z ERROR librdkafka: librdkafka: FAIL [thrd:localhost:9092/bootstrap]: localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT, 1 identical error(s) suppressed)
2025-11-20T17:27:58.177442Z ERROR rdkafka::client: librdkafka: Global error: BrokerTransportFailure (Local: Broker transport failure): localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT, 1 identical error(s) suppressed)
2025-11-20T17:28:12.180083Z ERROR common_kafka::transaction: Failed to fetch metadata from Kafka brokers: KafkaError (Metadata fetch error: BrokerTransportFailure (Local: Broker transport failure))
2025-11-20T17:28:12.184030Z ERROR librdkafka: librdkafka: FAIL [thrd:localhost:9092/bootstrap]: localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 1ms in state CONNECT)
2025-11-20T17:28:12.184146Z ERROR librdkafka: librdkafka: FAIL [thrd:localhost:9092/bootstrap]: localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT, 1 identical error(s) suppressed)
2025-11-20T17:28:12.184187Z ERROR rdkafka::client: librdkafka: Global error: BrokerTransportFailure (Local: Broker transport failure): localhost:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 1ms in state CONNECT) thread 'main' panicked at cymbal/src/main.rs:77:59: called Result::unwrap() on an Err value: KafkaError(KafkaError (Metadata fetch error: BrokerTransportFailure (Local: Broker transport failure))) note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Based on some other issues (#41581 and #32607 specifically) I wonder if this is because of a wider issue with Kafka on self-hosted installs

depends_on:
db:
condition: service_healthy
kafka:
condition: service_started

feature-flags:
image: ghcr.io/posthog/posthog/feature-flags:master
build:
Expand Down
7 changes: 7 additions & 0 deletions docker-compose.hobby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,13 @@ services:
file: docker-compose.base.yml
service: property-defs-rs

cymbal:
build:
context: ./posthog/rust
extends:
file: docker-compose.base.yml
service: cymbal
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cymbal service requires both database and Kafka to be available (as indicated by DATABASE_URL and KAFKA_HOSTS environment variables in the base configuration). Consider adding depends_on declarations similar to cyclotron-janitor (lines 261-265) to ensure proper service startup order:

depends_on:
    db:
        condition: service_healthy
    kafka:
        condition: service_started
Suggested change
service: cymbal
service: cymbal
depends_on:
db:
condition: service_healthy
kafka:
condition: service_started

Copilot uses AI. Check for mistakes.
Comment on lines +288 to +293
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: missing depends_on declarations. cymbal requires database, kafka, redis, and objectstorage to be available before starting. compare with feature-flags service at lines 312-314 which declares dependencies. without this, cymbal may attempt to start before its dependencies are ready, causing startup failures

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docker-compose.hobby.yml
Line: 288:293

Comment:
**logic:** missing `depends_on` declarations. cymbal requires database, kafka, redis, and objectstorage to be available before starting. compare with `feature-flags` service at lines 312-314 which declares dependencies. without this, cymbal may attempt to start before its dependencies are ready, causing startup failures

How can I resolve this? If you propose a fix, please make it concise.


livestream:
extends:
file: docker-compose.base.yml
Expand Down
Loading