build: Set up ducklake catalog in dev environment #41863
Merged
+280
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-ph
requested review from
EDsCODE and
fuziontech
and removed request for
a team
bill-ph
changed the title
bill-ph
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
Size Change: 0 B Total Size: 3.4 MB ℹ️ View Unchanged
|
webjunkie
reviewed
Nov 21, 2025
Comment on lines
+56
to
+63
| if ! python3 - <<'PY' >/dev/null 2>&1 | ||
| import duckdb # noqa: F401 | ||
| PY | ||
| then | ||
| echo "DuckLake requires the duckdb Python package." | ||
| echo "Run 'uv sync --active' (or activate Flox) before executing hogli start." | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
I'd argue we don't need to check for things that are in Python deps and installed with uv since that is pretty much a given they should be present.
Contributor
Author
There was a problem hiding this comment.
On new environment this would not trigger because people would run uv sync as part of setup process. But on an existing dev environment, if I'm not mistaken, people are not expected to run uv sync --active every time, and hogli start will fail.
EDsCODE
approved these changes
Nov 21, 2025
Collaborator
EDsCODE
left a comment
EDsCODE
left a comment
There was a problem hiding this comment.
works great (tested in existing environment)
bill-ph
force-pushed
the
ducklake-catalog-dev
branch
from
2da0e52 to
54ae59c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As first step for https://docs.google.com/document/d/1bBrl2plIXPqvrdZMyqABrg2ffPxEou5INBka-DArFiI/edit?tab=t.0#heading=h.2d3rsn8s6297
This sets up duck lake catalog and storage inside existing Postgres and MinIO dev containers.
How did you test this code?
It is fully automagic for new environment setup using flox, and requires manual
uv sync --activefor existing environment.Reviewer please try hogli start to verify error message on uv sync --active, and verify everything else runs after running
uv sync --activewith "DuckLake is up!" in log messages.