fix(experiments): update breakdown_value type.

[rodrigoi]

Problem

The BreakdownKeyType is not great.

export type BreakdownKeyType = integer | string | number | (integer | string | number)[] | null

Ideally, you want your types to be extended via unions or derived via utility types. In the case of BreakdownKeyType, you would like to treat it as a primitive and either allow it to be used as an array or make it nullable in the final type or variable.

Changes

We were inadvertently deriving BreakdownKeyType as an array when it already includes the array form as a union. That was causing some problems with type inference, which we fixed by adding a type assertion.

This change acknowledges the weirdness of BreakdownKeyType and documents why we are using primitives instead when defining breakdown_values.

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

[wiz-7ad640923b]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	1
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Total	1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[greptile-apps]

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

Size Change: 0 B

Total Size: 3.43 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	3.43 MB

_{compressed-size-action}