fix: Handle path dependencies from parent workspaces in sdist #2766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a source distribution for a crate that is excluded from
its parent workspace (or has its own workspace) but depends on sibling
crates in the parent workspace, maturin would panic with StripPrefixError.
This occurred because the code assumed that a path dependency's workspace
manifest would always be inside the sdist root, using
.unwrap()on theresult of
strip_prefix().The fix replaces
.unwrap()withif let Ok()to gracefully handleworkspace manifests outside the sdist boundary. When this occurs, we
skip including the external workspace manifest and log a debug message.
This is safe because:
Adds test case
lib_with_parent_workspace_path_dep_sdistthat reproducesthe scenario with a parent workspace excluding a crate that depends on
sibling workspace members.
Fixes scenarios like:
Resolves: HeliosSoftware/hfs#15 (real-world reproduction)
Small repo to reproduce issue: https://github.com/doug-helios/maturin-sdist-bug-repro