Normalize extra names in optional dependencies #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
konstin
reviewed
Oct 9, 2025
| } | ||
|
|
||
| #[test] | ||
| fn optional_dependencies_with_underscores() { |
Member
There was a problem hiding this comment.
In this test, we don't actually seem to be checking that extras match when their are written differently?
Contributor
Author
There was a problem hiding this comment.
Yeah, correct, but that specific case was still failing. I changed them now to be the inverse of one another, that should test all directions I suppose?
konstin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the normalized names for the extra lookup. The added test was failing on main and succeeding here. This caught my attention because of: prefix-dev/pixi#4706