Move lint after unit tests. #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is disruptive to code-build-test cycles to run lint on code that may still be generating red tests. This is especially annoying when you're adding or removing arguments to functions and the linter is bitching at you about linefeeds when you don't even know if the code works yet. Should block PRs, not unit test runs.
RafaelGSS
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is disruptive to code-build-test cycles to run lint on code that may still be generating red tests. This is especially annoying when you're adding or removing arguments to functions and the linter is blocking you over linefeeds when you don't even know if the code works yet.
Should block PRs, not unit test runs.