Skip to content

Conversation

@jdmarshall
Copy link
Contributor

github.com/libuv/libuv/issues/4773

This isn't fixed until Node 24.?? so your tests will be flaky as long as you're validating on 20 and 22

Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, that's irrelevant to us. Those additional 0.999 (or extra) shouldn't affect this test suite. Have you experienced a flaky test from time-mode?

This hasn't been fixed in any of Node.js versions (there's no ready fix by libuv team).

@RafaelGSS
Copy link
Owner

I will accept this since it seems necessary to rebase #139.

@RafaelGSS RafaelGSS merged commit cad6bfa into RafaelGSS:main Dec 7, 2025
5 of 6 checks passed
@jdmarshall
Copy link
Contributor Author

I’ve maintained CI pipelines for more than fifteen years and if there is one thing that experience has taught me time and time again, it’s how few flaky tests are required before people start ignoring legitimate problems in the build failures. “That build is always failing so I just reran it [three times]”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants