fix(test): [TEMP] default value of rosbridge arg #1108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for unreleased fix in rosbridge_server: RobotWebTools/rosbridge_suite@fc55974
MatthijsBurgh
requested review from
EzraBrooks,
bjsowa,
Copilot and
sea-bass
There was a problem hiding this comment.
Pull Request Overview
This PR adds an explicit argument to the rosbridge_websocket launch file to work around a default value issue in an unreleased fix from rosbridge_server. The change sets delay_between_messages to 0.0 to maintain current behavior until the upstream fix is released.
Key Changes:
- Added explicit
delay_between_messagesargument set to0.0in the rosbridge_websocket.launch include
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Duplicate of #1106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unreleased fix in rosbridge_server: RobotWebTools/rosbridge_suite@fc55974