Skip to content

fix: sanitize special characters in slugifyLikeString function #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepakbhagatiitr wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: sanitize special characters in slugifyLikeString function #6784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/lib/database/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,10 @@ describe('slugifyLikeString', () => {
const textSlugified = 'tesuto123';
expect(utils.slugifyLikeString(textToSlugify)).toBe(textSlugified);
});
test('slugify with special characters - should sanitize before slugifying', () => {
// Special characters should be replaced with '_' before slugifying
expect(utils.slugifyLikeString('test@#$123')).toBe('test___123');
expect(utils.slugifyLikeString('hello.world!')).toBe('hello_world_');
expect(utils.slugifyLikeString('user-name_123')).toBe('user_name_123');
});
});
4 changes: 2 additions & 2 deletions app/lib/database/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export const sanitizeLikeString = (str?: string): string | undefined => str?.rep
// slugifyLikeString('テスト123') => 'tesuto123'
export const slugifyLikeString = (str?: string) => {
if (!str) return '';
str?.replace(likeStringRegex, '_');
const slugified = slugify(str);
const sanitized = str.replace(likeStringRegex, '_');
const slugified = slugify(sanitized);
return slugified;
};

Expand Down