LibCore: Process overhaul #26383
Open
LibCore: Process overhaul #26383
+147
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
force-pushed
the
process
branch
from
ce1291f to
66cabe5
Compare
This removes the implicit `disown`ing of the Process in the destructor in favor of up front requests in the constructor. We also force users to exclusively and explicitly disown, wait or take the pid of the child. I hope that it will a good way to prevent API misuses, like calling C functions with the pid or `wait_for_termination` on a disowned child. It unfortunately prevents the usage of the "old" API with KeepAsChild::Yes, this is why there are some refactorings that come with the patch. This also should make it possible to implement KeepAsChild::No on other platforms.
LucasChollet
force-pushed
the
process
branch
from
66cabe5 to
410b8d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what the CI has to say about it!
I've checked that ladybird is booting.