file: Use Unicode quotation marks for audio metadata titles #26404
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove outdated FIXME and use proper Unicode quotation marks instead of ASCII quotes for audio file title metadata. SerenityOS terminal fonts now support these characters.
github-actions
bot
added
the
👀 pr-needs-review
linusg
suggested changes
Nov 15, 2025
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
I'm not sure what you did but these are regular ascii quotes, making this invalid code. I don't agree with the FIXME either, there's no reason to use fancy quotes here.
Contributor
|
+1, just removing the FIXME seems like the thing to do here 🙂 |
nico
added
⏳ pr-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an outdated FIXME and implements the improvement it mentioned.
The
fileutility now uses proper Unicode quotation marks (" ") foraudio metadata titles instead of ASCII quotes, as SerenityOS terminal
fonts fully support these characters now.