Skip to content

SystemServer: Don't use sleep to wait for the GPU to appear #26453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spholz merged 2 commits into from
Dec 4, 2025
Merged

SystemServer: Don't use sleep to wait for the GPU to appear #26453

spholz merged 2 commits into from
Dec 4, 2025
+28 −11

Conversation

@LucasChollet
Copy link
Member

@LucasChollet LucasChollet commented Dec 4, 2025

Before:

1.522 SystemServer(9): In activate_base_services_based_on_system_mode
2.523 SystemServer(9): GPU detected

After:

1.204 SystemServer(9): In activate_base_services_based_on_system_mode
1.215 SystemServer(9): GPU detected

Quite a juicy speed-up. Thanks for spotting it, @spholz.

@LucasChollet
SystemServer: Don't use sleep to wait for the GPU to appear
a474f57 
Using a FileWatcher allows us to get back to work as soon as the file
is created. On my system, it makes us wait 11ms instead of more than a
second.
@LucasChollet
SystemServer: Log a message after waiting for the GPU for one second
9e2683f
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 4, 2025
spholz
spholz approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@spholz spholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@spholz spholz added ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Dec 4, 2025
@spholz spholz linked an issue Dec 4, 2025 that may be closed by this pull request
SystemServer: Don't busy wait for /dev/gpu/connector0 #26444
Closed
@spholz spholz merged commit b1e5661 into SerenityOS:master Dec 4, 2025
13 checks passed
@github-actions github-actions bot removed the ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed label Dec 4, 2025
@LucasChollet LucasChollet deleted the wake_up branch December 4, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spholz spholz spholz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SystemServer: Don't busy wait for /dev/gpu/connector0

2 participants

@LucasChollet @spholz