JS-941 Fix: Disable all Node.js binaries in "without node" jobs #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach only disabled the first node binary found by `which`, but runners can have multiple node binaries (mise + system). This caused EmbeddedNode.java to still detect node and not deploy the embedded version. Changes: - Loop through ALL node binaries in PATH and disable each one - Verify node is no longer accessible after disabling - Fail the job if node is still found This ensures "Deployed node version" message appears in without node jobs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
hashicorp-vault-sonar-prod
bot
changed the title
Alpine QA jobs were failing because they were running Alpine artifacts (linux-x64-musl with Alpine Node.js binaries) on Ubuntu runners where the Alpine binaries don't work. Changes: - Split Alpine jobs out from Ubuntu matrix jobs - Use sonar-m-sidecar runner for Alpine jobs (supports Docker containers) - Run Alpine jobs in alpine:latest container - Remove node disabling step from Alpine jobs (not needed in fresh containers) New Alpine-specific jobs: - plugin_qa_without_node_alpine - plugin_qa_fast_without_node_alpine This allows testing Alpine artifacts in actual Alpine environments where the embedded Alpine Node.js binaries will work correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-941
Summary
Fix the "without node" jobs to properly disable ALL Node.js binaries, ensuring
EmbeddedNode.javadeploys the embedded Node.js runtime.Problem
The "without node" jobs were not showing "Deployed node version" in their logs, meaning they were using host Node.js instead of the embedded version.
The previous
remove_node_from_pathstep only disabled the first node binary found bywhich, but runners can have multiple node binaries:/home/runner/.local/share/mise/installs/node/22.11.0/bin/node/usr/bin/nodeor elsewhereAfter disabling the first one,
which nodewould find another, so SonarJS still detected node and didn't deploy the embedded version.Changes
Expected Result
After this fix, the "without node" jobs should show "Deployed node version" messages in their logs, confirming that
EmbeddedNode.javais deploying the embedded Node.js runtime.Test plan
🤖 Generated with Claude Code