SLVS-2718 Add checkbox to GeneralOptionsDialogPage #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnaskos-sonar
approved these changes
Nov 28, 2025
| browserService = Substitute.For<IBrowserService>(); | ||
| testSubject = new GeneralOptionsDialogControlViewModel(settings, browserService, openSettingsFileCommand); | ||
| focusOnNewCodeService = Substitute.For<IFocusOnNewCodeServiceUpdater>(); | ||
| focusOnNewCodeService.Current.Returns(new FocusOnNewCodeStatus(false)); // todo |
Contributor
Author
There was a problem hiding this comment.
forgot to remove it after fixing the tests
Base automatically changed from
gb/report-view-stateful-new-code
to
feature/persistent-new-code
November 28, 2025 13:39
georgii-borovinskikh-sonarsource
force-pushed
the
gb/new-code-general-options-checkbox
branch
from
9234f6b to
bef1922
Compare
georgii-borovinskikh-sonarsource
merged commit e07ca64
into
feature/persistent-new-code
3 checks passed
georgii-borovinskikh-sonarsource
deleted the
gb/new-code-general-options-checkbox
branch
SonarQube reviewer guideSummary: Add "Focus on New Code" toggle to general settings with UI and service integration. Review Focus: Ensure Start review at:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.