-
-
Notifications
You must be signed in to change notification settings - Fork 955
Balinese Sky Culture #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Balinese Sky Culture #4625
Conversation
Updated the description of Balinese sky culture and corrected various phrases for clarity and accuracy.
Good to read this. I am mentally elsewhere and don't want to switch branches now. Qt6.8 is current LTS (6.10 is out, and 6.11 will likely be next LTS), and I hope the CI provides it. Presumably most users in this field are on Windows, and a lot has changed between 6.5 and 6.8, so this seems relevant. If older linux distros don't have it, something has to remain behind, unfortunately. |
Removed 'Fair Use' section and updated author credits.
Interestingly, on Ubuntu 20.04 with Qt 6.9.3 the hack is required: diff --git a/src/main.cpp b/src/main.cpp
index e184ab3dcf..0bc0db4bd8 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -434,6 +434,7 @@ int main(int argc, char **argv)
#ifdef Q_OS_WIN
QFontDatabase::addApplicationFallbackFontFamily(QChar::Script_Cuneiform, "Segoe UI Historic");
#endif
+ QFontDatabase::addApplicationFallbackFontFamily(QChar::Script_Balinese, "Noto Serif Balinese");
#endif
// Set the default application font and font size. |
|
|
@youlaafifah @sushoff is it ready to review after fixes? |
|
Hmm... I see troubles in table - one column missing? |
Removed 'Original Balinese' column from the table.
alex-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK for me now
|
skycultures/balinese/description.md
Outdated
| ### Sky | ||
|
|
||
| ## Description | ||
| This sky culture has one small lintang system called "Kartika". Please zoom into the Pleiades to see it clearly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "please" is suitable for an educational text. The text is not supposed to ask the reader to do anything, it just informs. If you're afraid of "impolite" imperative, you can rephrase it like "You can see it clearly if you zoom into the Pleiades".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
|
|
||
| ##### Kala Sungsang | ||
| Kala Sungsang is an upside-down demon. Sungsang itself is inverted. Kala also means time. So the duty of this demon is to remind people who forget or even neglect the time. | ||
| <img width="255" src="illustrations/descr_pics/Ra_U.jpg"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
The constellation names in the description must use the |
|
Also, I've just added a validator for the References section to |
|
One more thing: section headers should have a blank line before and after (except for the very first level-1 section, of course), see Markdown Guide/Heading Best Practices. |
|
To validate the SC without me having to repeatedly say what's wrong, you can do the following (commands for bash): REMOTE=upstream # replace "upstream" with whatever your remote for upstream Stellarium is called
git fetch $REMOTE
git checkout $REMOTE/master -- util/skycultures/generate-pot.pyMake sure that This will emit some warnings about issues that should be fixed (if any remain). It will also generate a To undo the changes to the script (so that you could commit your own changes), you can do this: git reset -- util/skycultures/generate-pot.py
git checkout -- util/skycultures/generate-pot.py |

Description
Adds a new indigenous sky culture from Indonesia, Southeast Asia, Balinese Sky Culture, to Stellarium. This is an original, fully invented ethno-astronomical tradition to expand Stellarium's collection of global sky cultures.
Stellarium is an open source and letting any researchers to make a contribution. Since there is no Indonesian sky culture inside the database, I am willing to add one of many Indonesian sky culture. Stellarium is a great space for preserving the indigenous sky culture. Letting this sky culture to have a space in here, will help my country to prevent their sky culture extinction.
This is a standalone sky culture directory with no external dependencies.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
I have added the "Bali" folder inside the "skyculture" directory/folder inside my laptop. When I am opening the Stellarium, all of the Balinese sky culture definitions are working.
In making the definition, I was creating the stickfigure and everything with SCM (Sky Culture Maker; since I have a poster and presented it on IAUS 399). I used GIMP for the image processing, like creating transparent layer. Then I put all together and test them in Stellarium v 25.2
All is working, but only the native name is not. They are displaying blocks and seems can not read the text. I put the native names with Balinese text (aksara Bali). It is working inside the editor text, but not in Stellarium display.
Test Configuration:
Checklist: