Skip to content

Conversation

@DarthGandalf
Copy link
Contributor

https://bugs.gentoo.org/966288

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added the dependencies dependencies (such like ShowMySky, QXlsx, etc.) related issues label Nov 22, 2025
@alex-w
Copy link
Member

alex-w commented Nov 22, 2025

The second patch is better, but not very accurate still…

@alex-w alex-w added the qt Issues, related to Qt framework label Nov 22, 2025
@alex-w alex-w added this to the 25.4 milestone Nov 22, 2025
@DarthGandalf
Copy link
Contributor Author

What else is missing?

I thought about comparing Qt${QT_VERSION_MAJOR}_VERSION instead of Qt6_VERSION, but this seems clearer to me, and in the case of Qt5 it's also false as expected

@alex-w
Copy link
Member

alex-w commented Nov 22, 2025

What else is missing?

Not missing, but splitting option onto parts may be painful in future…

I thought about comparing Qt${QT_VERSION_MAJOR}_VERSION instead of Qt6_VERSION, but this seems clearer to me, and in the case of Qt5 it's also false as expected

Comparing Qt${QT_VERSION_MAJOR}_VERSION is better, but you are right - Qt6_VERSION seems clearer here. In any way comments is needed here.

@DarthGandalf
Copy link
Contributor Author

Added comment

@alex-w alex-w merged commit e7fd3f3 into Stellarium:master Nov 23, 2025
16 checks passed
uwes-ufo added a commit to uwes-ufo/stellarium that referenced this pull request Nov 23, 2025
uwes-ufo added a commit to uwes-ufo/stellarium that referenced this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies dependencies (such like ShowMySky, QXlsx, etc.) related issues qt Issues, related to Qt framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants