[WIP] libarchive-based dearchiving

[YoshiRulz]

tests fail for ¯\_(ツ)_/¯ reasons

[Morilli]

Dare I ask what this is for?

[YoshiRulz]

It supports more formats than SharpCompress.

[SuuperW]

I assume the particular format you're interested in is zstd, and you want to simplify our zstd use. Including making it so that zstd compressed files in our archives won't need the .zst extension anymore and can be edited via text editor more easily.

[YoshiRulz]

I don't even know what you're suggesting.
My goal here is to use the de facto standard library for working with archives, and in doing so add support for .tar.gz, .tar.bz2, .tar.lz, and sure why not .tar.zst.

BizHawk/src/BizHawk.Client.Common/SharpCompressDearchivalMethod.cs

Lines 70 to 80 in db070b9

	public IReadOnlyCollection<string> AllowedArchiveExtensions { get; } = new[]
	{
	".7z",
	".gz",
	".rar",
	".tar",
	// /*.tar*/".bz2", ".tb2", ".tbz", ".tbz2", ".tz2",
	// /*.tar.gz,*/ ".taz", ".tgz",
	// /*.tar*/".lz",
	".zip",
	};

[SuuperW]

My goal here is to use the de facto standard

Your goal is to "be like everybody else", then? Or is there any use case/feature that this enables, or issue that it fixes?

It doesn't look like you're actually using this new library anyway. I have no idea where or how you might intend to use it.

[RetroEdit]

I would imagine opening games inside more types of archives would be the intended use-case. That is a useful feature.

[YoshiRulz]

Currently the dearchival method is set globally on program startup, so it would be a 1-line change to use only libarchive:

BizHawk/src/BizHawk.Client.EmuHawk/Program.cs

Line 181 in db070b9

HawkFile.DearchivalMethod = SharpCompressDearchivalMethod.Instance;

[CasualPokePlayer]

and in doing so add support for .tar.gz, .tar.bz2, .tar.lz, and sure why not .tar.zst

All of those are already supported by SharpCompress. At most they are just not supported within BizHawk's usage of SharpCompress.