[TASK] Replace md5/sha1 calls with hash method #4437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
added
BACKPORTABLE
md5 and sha1 might get deprecated - it's cleaner/better to use that hash method and apply the algorithm there. md5/sha1 should we rewritten to use the hash method: https://wiki.php.net/rfc/deprecations_php_8_4 ` Users may replace the use of the standalone functions as follows if they still require the use of MD5 and SHA-1: [md5](http://www.php.net/md5)($data, $binary = false) → [hash](http://www.php.net/hash)('md5', $data, $binary = false) [sha1](http://www.php.net/sha1)($data, $binary = false) → [hash](http://www.php.net/hash)('sha1', $data, $binary = false) [md5_file](http://www.php.net/md5_file)($filename, $binary = false) → [hash_file](http://www.php.net/hash_file)('md5', $filename, $binary = false) [sha1_file](http://www.php.net/sha1_file)($filename, $binary = false) → [hash_file](http://www.php.net/hash_file)('sha1', $filename, $binary = false)` Fixes: TYPO3-Solr#4436
dkd-kaehm
force-pushed
the
task-4436-replace-md5-sha1
branch
from
62171c2 to
8804e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Fixes deprecated PHP 8.4 calls to md5/sha1 with using hash instead
How to test
Automatic tests should cover these changes
Fixes: #4436