Skip to content

Conversation

@dv255037
Copy link
Collaborator

Description

This PR addresses code review feedback by adding validation, removing redundant code, and updating configuration files.

Changes Made

1. Added Compact Constructors with Null Validation

  • Ensures all non-nullable fields are validated at construction time
  • Improves API robustness by failing fast on invalid input

2. Code Quality Improvements

  • Simplified code for better readability and maintainability

3. Test Resource Management

  • Ensures consistent cleanup across test classes

4. Configuration Updates

  • Ensures the Teradata connector is included in the Trino server distribution

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@github-actions github-actions bot added the docs label Nov 20, 2025
@dv255037 dv255037 changed the base branch from master to teradata-connector November 20, 2025 17:15
@dv255037 dv255037 requested a review from sc250072 November 20, 2025 17:24
@sc250072 sc250072 closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants