Skip to content

Conversation

@nsiccha
Copy link
Contributor

@nsiccha nsiccha commented Nov 26, 2025

Closes #476

@nsiccha nsiccha marked this pull request as draft November 26, 2025 10:05
@nsiccha
Copy link
Contributor Author

nsiccha commented Nov 26, 2025

AFAICT, at least the main tests pass locally for julia 1.12.2 - let's see what github says.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (52a7737) to head (3d47e8a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/riemannian/integrator.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   77.66%   77.58%   -0.09%     
==========================================
  Files          21       21              
  Lines        1240     1240              
==========================================
- Hits          963      962       -1     
- Misses        277      278       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nsiccha nsiccha marked this pull request as ready for review November 26, 2025 10:30
@nsiccha nsiccha requested a review from penelopeysm November 26, 2025 10:32
@nsiccha
Copy link
Contributor Author

nsiccha commented Nov 26, 2025

Apparently the Riemannian stuff has 0% test coverage? In any case, it looks like the important tests will pass now - I've assigned @penelopeysm to review.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks Niko.

@nsiccha nsiccha merged commit 0dbc2ee into TuringLang:main Nov 27, 2025
19 of 21 checks passed
J-Price-3 pushed a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests fail on github (due to JET?)

2 participants