-
Notifications
You must be signed in to change notification settings - Fork 15
Integrate DifferentiationInterface.jl for gradient computation #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8dfc800
Simplify the workflow for computing model gradients
shravanngoswamii d77bbac
update docs and bump version to 0.10.4
shravanngoswamii 199ba71
run JuliaFormatter
shravanngoswamii 1e515d1
try to fix benchmark failures
shravanngoswamii f0135a8
format
shravanngoswamii c80dc9f
add Mooncake and update docs
shravanngoswamii ef36d7d
remove symbols
shravanngoswamii 2f8b72d
Update JuliaBUGS/test/ext/JuliaBUGSAdvancedHMCExt.jl
yebai 653540f
Merge branch 'main' into sg/#380
yebai a182845
Merge branch 'main' into sg/#380
sunxd3 a44fda5
Refactor BUGSModelWithGradient and remove LogDensityProblemsAD support
sunxd3 c130d78
Merge main into sg/#380
sunxd3 7d033d8
Fix AD gradient function signature and add AD compatibility tests
sunxd3 94fb6c5
format
sunxd3 8aee4d2
remove redundant lines in benchmark code
sunxd3 cd1df5e
various cleaning up
sunxd3 a501476
Update examples to use new BUGSModelWithGradient API
sunxd3 e059ad8
update example doc
sunxd3 4509463
fix hmc test error
sunxd3 d6fc462
disable progress bar example doc
sunxd3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,6 @@ Manifest.toml | |
| *.local.* | ||
|
|
||
| # gitingest generated files | ||
| digest.txt | ||
| digest.txt | ||
|
|
||
| tmp/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really non-breaking to make such a big change?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
adtypeparameter is optional (defaults to nothing), all existing code works unchanged, so this is backward compatible.However, if you prefer
0.11.0, I can change it.