Merge pull request #2503 from ViewComponent/herb-compat

joelhawksley · web-flow · commit 6d91b0454c02 · 2025-11-20T12:00:42.000-07:00
test compatibility with Herb
diff --git a/Gemfile b/Gemfile
@@ -30,6 +30,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails"
   gem "rubocop-md", "~> 2"
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -145,6 +145,14 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2-aarch64-linux-gnu)
+    herb (0.8.2-aarch64-linux-musl)
+    herb (0.8.2-arm-linux-gnu)
+    herb (0.8.2-arm-linux-musl)
+    herb (0.8.2-arm64-darwin)
+    herb (0.8.2-x86_64-darwin)
+    herb (0.8.2-x86_64-linux-gnu)
+    herb (0.8.2-x86_64-linux-musl)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -265,6 +273,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -427,6 +438,7 @@ DEPENDENCIES
   rails (~> 8)
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails
   rubocop-md (~> 2)
@@ -444,7 +456,7 @@ DEPENDENCIES
   yard-activesupport-concern (< 1)
 
 RUBY VERSION
-   ruby 3.4.3p32
+   ruby 3.3.0p0
 
 BUNDLED WITH
    2.6.2
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -18,6 +18,10 @@ nav_order: 6
 
     *Hans Lemuet*
 
+* Test compatibility with Herb/ReActionView.
+
+    *Joel Hawksley*
+
 ## 4.1.1
 
 * Add Consultport to list of companies using ViewComponent.
diff --git a/gemfiles/rails_7.1.gemfile b/gemfiles/rails_7.1.gemfile
@@ -12,7 +12,7 @@ group :development, :test do
   gem "appraisal-run", "~> 1.1"
   gem "benchmark-ips", "~> 2"
   gem "better_html"
-  gem "bundler", "~> 2"
+  gem "bundler"
   gem "capybara", "~> 3"
   gem "cuprite"
   gem "dry-initializer", require: true
@@ -26,6 +26,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails", "~> 7"
   gem "rubocop-md", "~> 2"
diff --git a/gemfiles/rails_7.1.gemfile.lock b/gemfiles/rails_7.1.gemfile.lock
@@ -152,6 +152,14 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2-aarch64-linux-gnu)
+    herb (0.8.2-aarch64-linux-musl)
+    herb (0.8.2-arm-linux-gnu)
+    herb (0.8.2-arm-linux-musl)
+    herb (0.8.2-arm64-darwin)
+    herb (0.8.2-x86_64-darwin)
+    herb (0.8.2-x86_64-linux-gnu)
+    herb (0.8.2-x86_64-linux-musl)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -274,6 +282,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -423,7 +434,7 @@ DEPENDENCIES
   appraisal-run (~> 1.1)
   benchmark-ips (~> 2)
   better_html
-  bundler (~> 2)
+  bundler
   capybara (~> 3)
   cuprite
   dry-initializer
@@ -438,6 +449,7 @@ DEPENDENCIES
   rails (~> 7.1.0)
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails (~> 7)
   rubocop-md (~> 2)
diff --git a/gemfiles/rails_7.2.gemfile b/gemfiles/rails_7.2.gemfile
@@ -12,7 +12,7 @@ group :development, :test do
   gem "appraisal-run", "~> 1.1"
   gem "benchmark-ips", "~> 2"
   gem "better_html"
-  gem "bundler", "~> 2"
+  gem "bundler"
   gem "capybara", "~> 3"
   gem "cuprite"
   gem "dry-initializer", require: true
@@ -26,6 +26,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails", "~> 7"
   gem "rubocop-md", "~> 2"
diff --git a/gemfiles/rails_7.2.gemfile.lock b/gemfiles/rails_7.2.gemfile.lock
@@ -146,6 +146,14 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2-aarch64-linux-gnu)
+    herb (0.8.2-aarch64-linux-musl)
+    herb (0.8.2-arm-linux-gnu)
+    herb (0.8.2-arm-linux-musl)
+    herb (0.8.2-arm64-darwin)
+    herb (0.8.2-x86_64-darwin)
+    herb (0.8.2-x86_64-linux-gnu)
+    herb (0.8.2-x86_64-linux-musl)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -267,6 +275,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -416,7 +427,7 @@ DEPENDENCIES
   appraisal-run (~> 1.1)
   benchmark-ips (~> 2)
   better_html
-  bundler (~> 2)
+  bundler
   capybara (~> 3)
   cuprite
   dry-initializer
@@ -431,6 +442,7 @@ DEPENDENCIES
   rails (~> 7.2.0)
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails (~> 7)
   rubocop-md (~> 2)
diff --git a/gemfiles/rails_8.0.gemfile b/gemfiles/rails_8.0.gemfile
@@ -12,7 +12,7 @@ group :development, :test do
   gem "appraisal-run", "~> 1.1"
   gem "benchmark-ips", "~> 2"
   gem "better_html"
-  gem "bundler", "~> 2"
+  gem "bundler"
   gem "capybara", "~> 3"
   gem "cuprite"
   gem "dry-initializer", require: true
@@ -26,6 +26,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails", "~> 8"
   gem "rubocop-md", "~> 2"
diff --git a/gemfiles/rails_8.0.gemfile.lock b/gemfiles/rails_8.0.gemfile.lock
@@ -143,6 +143,14 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2-aarch64-linux-gnu)
+    herb (0.8.2-aarch64-linux-musl)
+    herb (0.8.2-arm-linux-gnu)
+    herb (0.8.2-arm-linux-musl)
+    herb (0.8.2-arm64-darwin)
+    herb (0.8.2-x86_64-darwin)
+    herb (0.8.2-x86_64-linux-gnu)
+    herb (0.8.2-x86_64-linux-musl)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -263,6 +271,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -413,7 +424,7 @@ DEPENDENCIES
   appraisal-run (~> 1.1)
   benchmark-ips (~> 2)
   better_html
-  bundler (~> 2)
+  bundler
   capybara (~> 3)
   cuprite
   dry-initializer
@@ -428,6 +439,7 @@ DEPENDENCIES
   rails (~> 8.0.0)
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails (~> 8)
   rubocop-md (~> 2)
@@ -448,4 +460,4 @@ RUBY VERSION
    ruby 3.4.4p34
 
 BUNDLED WITH
-   2.6.9
+   2.6.7
diff --git a/gemfiles/rails_8.1.gemfile b/gemfiles/rails_8.1.gemfile
@@ -12,7 +12,7 @@ group :development, :test do
   gem "appraisal-run", "~> 1.1"
   gem "benchmark-ips", "~> 2"
   gem "better_html"
-  gem "bundler", "~> 2"
+  gem "bundler"
   gem "capybara", "~> 3"
   gem "cuprite"
   gem "dry-initializer", require: true
@@ -26,6 +26,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails", "~> 8"
   gem "rubocop-md", "~> 2"
diff --git a/gemfiles/rails_8.1.gemfile.lock b/gemfiles/rails_8.1.gemfile.lock
@@ -145,6 +145,14 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2-aarch64-linux-gnu)
+    herb (0.8.2-aarch64-linux-musl)
+    herb (0.8.2-arm-linux-gnu)
+    herb (0.8.2-arm-linux-musl)
+    herb (0.8.2-arm64-darwin)
+    herb (0.8.2-x86_64-darwin)
+    herb (0.8.2-x86_64-linux-gnu)
+    herb (0.8.2-x86_64-linux-musl)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -265,6 +273,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -412,7 +423,7 @@ DEPENDENCIES
   appraisal-run (~> 1.1)
   benchmark-ips (~> 2)
   better_html
-  bundler (~> 2)
+  bundler
   capybara (~> 3)
   cuprite
   dry-initializer
@@ -427,6 +438,7 @@ DEPENDENCIES
   rails (~> 8.1.0)
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails (~> 8)
   rubocop-md (~> 2)
@@ -447,4 +459,4 @@ RUBY VERSION
    ruby 3.4.7p58
 
 BUNDLED WITH
-   2.6.2
+   2.6.7
diff --git a/gemfiles/rails_main.gemfile b/gemfiles/rails_main.gemfile
@@ -27,6 +27,7 @@ group :development, :test do
   gem "puma", ">= 6"
   gem "rake", "~> 13"
   gem "rails-dom-testing", "~> 2.3.0"
+  gem "reactionview"
   gem "redis"
   gem "rspec-rails", "~> 8"
   gem "rubocop-md", "~> 2"
diff --git a/gemfiles/rails_main.gemfile.lock b/gemfiles/rails_main.gemfile.lock
@@ -7,7 +7,7 @@ GIT
 
 GIT
   remote: https://github.com/rails/rails.git
-  revision: cf4e3c508adf930eb70e4b3e6e16d2ca83b7e9b3
+  revision: 990198b7b5f4a3a3d0d59bc1bcac58efa405f527
   branch: main
   specs:
     actioncable (8.2.0.alpha)
@@ -181,6 +181,7 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    herb (0.8.2)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.1)
@@ -281,6 +282,9 @@ GEM
       erb
       psych (>= 4.0.0)
       tsort
+    reactionview (0.1.6)
+      actionview (>= 7.0)
+      herb (>= 0.7.5, < 1.0.0)
     redis (5.4.1)
       redis-client (>= 0.22.0)
     redis-client (0.26.1)
@@ -444,6 +448,7 @@ DEPENDENCIES
   rails!
   rails-dom-testing (~> 2.3.0)
   rake (~> 13)
+  reactionview
   redis
   rspec-rails (~> 8)
   rubocop-md (~> 2)
diff --git a/test/sandbox/app/components/herb_component.html.herb b/test/sandbox/app/components/herb_component.html.herb
@@ -0,0 +1,4 @@
+<div>
+  <%= content %>
+  <%= @message %>
+</div>
diff --git a/test/sandbox/app/components/herb_component.rb b/test/sandbox/app/components/herb_component.rb
@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class HerbComponent < ViewComponent::Base
+  def initialize(message:)
+    @message = message
+  end
+end
diff --git a/test/sandbox/config/application.rb b/test/sandbox/config/application.rb
@@ -34,6 +34,7 @@
 require "haml"
 require "slim"
 require "jbuilder"
+require "reactionview"
 
 module Sandbox
   class Application < Rails::Application
diff --git a/test/sandbox/test/rendering_test.rb b/test/sandbox/test/rendering_test.rb
@@ -295,6 +295,13 @@ def test_renders_erb_template
     assert_text("bar")
   end
 
+  def test_renders_herb_template
+    render_inline(HerbComponent.new(message: "bar")) { "foo" }
+
+    assert_text("foo")
+    assert_text("bar")
+  end
+
   def test_renders_partial_template
     render_inline(PartialComponent.new)
 
