-
Notifications
You must be signed in to change notification settings - Fork 35
Improve test runner ergonomics #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes errors due pylint use of deprecated package.
7b927cc to
f54e568
Compare
|
Rebased on top of #151. |
a1be0b5 to
8445288
Compare
Add `./run-tests` executable that doesn't require arguments, automatically detecting available runtimes and tests. Simplify `README.md` accordingly. Console test case reporter more concise and useful: - Single line to indicate total results - One copy-pastable command line per failure - Requires refactors to record command lines, remove cwd change Allow testing multiple engines in one run. - Required changing `TEST_RUNTIME_EXE` environment variable convention to one env var per executable - Requires refactor to collect which runtime ran a testcase
8445288 to
c2b2f58
Compare
|
So. Before, you would run this: And you would get output like this: before.txt After this change, you would have to specify the Wasmtime runtime via the And you get similar output, though there are section headings printed as we run tests, and the synopsis is shorter and shows the commands to re-run: after-wasi-test-runner.txt But the neat thing is that after, you can just run this: That gives you similar output, though it prints some info indicating how it detects runtimes in the beginning: In future I would like for WDYT @alexcrichton @pchickey @loganek ? In future I would like to:
|
|
That looks great to me! I like having copy/pastable commands at the end and I also like the aspiration of "here's the command for running the runtime directly" to get printed eventually as that's exactly what I'd be looking for when debugging things. |
Don't go beyond a page or so of output.
|
Added on a patch so that Also there is color on a console. |
Add
./run-testsexecutable that doesn't require arguments, automatically detecting available runtimes and tests.Simplify
README.mdaccordingly.Console test case reporter more concise and useful:
Allow testing multiple engines in one run.
TEST_RUNTIME_EXEenvironment variable convention to one env var per executable