-
Notifications
You must be signed in to change notification settings - Fork 13
✨ Add "View details" dialog for long JupyterLab notifications #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MFA-X-AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it works very well!
Slightly related, I think I missed this in the previous PR, I noticed for components with libraries that exist in our manifest, the message is formatted like this:
You need to install the "xai_components/xai_sqlite" library to use "SqliteFetchAll" component.
Could you update it so it shows xai_sqlite or sqlite? Thanks!
MFA-X-AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional thing I'd like you to do - currently once the longer preview is active, pressing the copy button dismisses the popup. Ideally it should keep it and either change the icon to "Copied!" or fire a notification.
MFA-X-AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Unfortunately I don't see copy error button here.
If I check F12, it says:
Error reloading component from path: xai_components/xai_utils/utils.py. Error: Cannot read properties of undefined (reading 'class')
Aside from that, the implementation does look much more complicated than I thought for a small gain. I did check the previous issue, and someone did raise it before but it hasn't been reponded. Since it's not natively supported in Jupyterlab, let's go with a simple notification for the copied instead.
|
The copy button is actually located at the top-right corner of the dialog. |
…tails dialog" This reverts commit 9a353a4.
Description
This PR enhances the notification system in Xircuits by adding a "View details" button to all JupyterLab notifications that exceed 140 characters. Clicking the button opens a dialog displaying the full message with an option to copy it to the clipboard.
Pull Request Type
Type of Change
Tests
Notification.info,Notification.error, etc.) are all augmented globally.Tested on? Specify Version.