Skip to content

Conversation

@sirfergy
Copy link

@sirfergy sirfergy commented Feb 1, 2025

Following what was done here to fix bleno to get noble working again for newer linux kernels.

@sirfergy
Copy link
Author

sirfergy commented Feb 5, 2025

@rzr would you mind reviewing this one?

@sirfergy
Copy link
Author

sirfergy commented Feb 5, 2025

Although it looks like the actions on this repo need to be fixed, let me see if that's something I can do. But before I do that, would you mind ack'ing that you can approve?

@sirfergy sirfergy changed the title Reaction to linux kernel change for bluetooth Reaction to linux kernel change for bluetooth + fix build! Feb 5, 2025
@sirfergy
Copy link
Author

sirfergy commented Feb 5, 2025

@rzr I've fixed the build, the only thing that fails is codecove upload which I'm hoping this repo has a token. Hope you can review this PR!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we want user committed binaries in sources, do we ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it wasn't in .gitignore so I assumed it was to be merged. I can revert and update .gitignore.

@rzr
Copy link

rzr commented Feb 6, 2025

May you split the PR in several smaller ones to check everything is fine before merging

@sirfergy
Copy link
Author

sirfergy commented Feb 6, 2025

Happy to! What are you looking to see split? Outside of the workflow changes and version bumps there was only one code change.

@sirfergy
Copy link
Author

sirfergy commented Feb 6, 2025

I closed this PR in favor of #353 and #351. Once those merge I'll open a follow up that bumps the package version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants