Skip to content

Conversation

@dickmao
Copy link

@dickmao dickmao commented Jan 26, 2023

The advised function calls find-library-name on library. Not following suit in the advice causes non-existent files to be opened.

The advised function calls find-library-name on library.
Not following suit in the advice causes non-existent files to be opened.
Copy link

@basil-conto basil-conto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #408 and #413 are addressed (i.e. if hydra.git and elpa.git are brought back in sync), then this PR should no longer be needed.

;; if it found the point.
(unless (cdr ad-return-value)
(with-current-buffer (find-file-noselect library)
(with-current-buffer (find-file-noselect (find-library-name library))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

(with-current-buffer (car ad-return-value) ...)

instead?

See #413 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants