Add arm64 support #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
commented
Jan 27, 2025
Comment on lines
+60
to
+63
| # TODO enable running the tests on arm64 once actions/runner supports Alpine arm64 | ||
| # https://github.com/actions/runner/pull/3665 | ||
| #- arch: arm64 | ||
| # runner: ubuntu-24.04-arm |
Author
There was a problem hiding this comment.
Looks like running the tests will have to wait until actions/runner#3665 is merged, because they obviously fail due to the block in the actions/runner repo.
This was referenced Jan 27, 2025
dennisameling
commented
Jan 28, 2025
| with: | ||
| name: alpine_nodejs_${{github.event.inputs.NodeVersion}} | ||
| # Create GitHub release | ||
| - uses: actions/create-release@master |
Author
There was a problem hiding this comment.
This action is unmaintained and the repo has been archived: https://github.com/actions/create-release
| Alpine node.js ${{github.event.inputs.NodeVersion}} | ||
| # Upload release assets | ||
| - name: Upload Release Asset | ||
| uses: actions/[email protected] |
Author
There was a problem hiding this comment.
This action in unmaintained and the repo has been archived: https://github.com/actions/upload-release-asset
|
@TingluoHuang @joshmgross @actions/actions-runtime may i ask for review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor of #7
Uses the now-available
ubuntu-24.04-armrunner to run natively on arm64.Here's a test run: https://github.com/dennisameling/alpine_nodejs/actions/runs/12998098115
And here's the release it created: https://github.com/dennisameling/alpine_nodejs/releases/tag/v20.18.2