-
Notifications
You must be signed in to change notification settings - Fork 614
Enable setting up of go on ppc64/ppc64le systems. #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
00beeea to
9474567
Compare
|
Hi @priyagupta108, A gentle reminder for your review on this PR when time permits. Thanks! |
|
Hi @HarithaVattikuti, @priya-kinthali and @aparnajyothi-y, Could you please take a look at the changes in this PR and let me know your thoughts? Thanks! |
|
Hi @HarithaVattikuti, @priya-kinthali @aparnajyothi-y and @priyagupta108, Could you please take a look at the changes in this PR and let me know your thoughts? Thanks! |
1 similar comment
|
Hi @HarithaVattikuti, @priya-kinthali @aparnajyothi-y and @priyagupta108, Could you please take a look at the changes in this PR and let me know your thoughts? Thanks! |
|
Hey @HarithaVattikuti, @priya-kinthali @aparnajyothi-y and @priyagupta108, Can you please help to review this PR when time permits? I'm really looking forward to having this support added to enable installation of Go through GH actions and would be happy to address comments if any. Thanks! |
|
Hey @HarithaVattikuti, @aparnajyothi-y and @priyagupta108, I'm really looking forward to having these changes added to main. Kindly help to review this PR when time permits. Please let me know if there are any concerns. Thanks! |
|
Hey @HarithaVattikuti, @aparnajyothi-y and @priyagupta108, I'm really looking forward to having these changes added to main. Kindly help to review this PR when time permits. Please let me know if there are any concerns. It's close to a year. Even a simple comment on what could be the next steps can help me do the needful to have the changes merged. Thanks! |
1 similar comment
|
Hey @HarithaVattikuti, @aparnajyothi-y and @priyagupta108, I'm really looking forward to having these changes added to main. Kindly help to review this PR when time permits. Please let me know if there are any concerns. It's close to a year. Even a simple comment on what could be the next steps can help me do the needful to have the changes merged. Thanks! |
|
Hi @kishen-v, Thank you for the contribution! just to clarify the practical impact of this change, GitHub-hosted runners currently do not support ppc64 or ppc64le architectures. Even if this PR is merged, it will not enable ppc64le on hosted runners, as the Go binary still cannot run without a matching runner. However, if you are using a self-hosted runner configured for ppc64le, the action should attempt to download the correct binaries. Please try explicitly setting the architecture in your workflow as follows and verify that it is downloading the correct binaries: |
|
Hey @gowridurgad, Thanks for taking a look at the PR. You’re absolutely right that GitHub hosted runners don’t currently support PowerPC. That said, since the existing code comment already notes that it’s future-proofed, this change helps make the action usable on self-hosted runners. Without it, users would need to maintain an additional workflow file just for the ppc64le architecture. With the recent announcement about GitHub Actions support for IBM Power, IBM Z, and IBM LinuxONE Please consider this change to help enable easier support for Power based runners going forward. Thanks!! |
Description:
This change enables to install go on ppc64/ppc64le systems based on endianness.
The existing flow tends to pick ppc64 bundle for both big endian/little endian machines as
os.arch()does not have the capability to determine the endianness, which leads to installing an unsupported bundle in the case of ppc64le.Related issue:
Fixes #517
Check list: