Enhance error logging for network failures to include endpoint/IP details, add retry mechanism and update workflows to use macos-15-intel #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahabaleshwars
previously approved these changes
Oct 24, 2025
Closed
5 tasks
aparnajyothi-y
previously approved these changes
Oct 29, 2025
priya-kinthali
dismissed stale reviews from aparnajyothi-y and mahabaleshwars
via
07e4e83
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling and introduces retry logic for Java installation failures, particularly for transient network issues. It also updates GitHub Actions workflow configurations to use a newer macOS runner.
Key changes:
- Adds retry logic with up to 4 attempts for network-related errors (ETIMEDOUT, ECONNRESET, etc.) and HTTP errors (429, 502, 503, 504)
- Improves error logging to include detailed information about aggregate errors and network failures
- Updates CI workflows to use
macos-15-intelinstead ofmacos-13
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/distributions/base-installer.ts | Adds retry loop with network error detection, enhanced error logging with support for aggregate errors, console timer cleanup, and null check for foundJava |
| dist/setup/index.js | Compiled JavaScript output reflecting the TypeScript changes |
| package-lock.json | Removes extra blank line at the beginning of the file |
| .github/workflows/e2e-versions.yml | Updates macOS runner from macos-13 to macos-15-intel |
| .github/workflows/e2e-cache.yml | Updates macOS runner from macos-13 to macos-15-intel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
priya-kinthali
changed the title
aparnajyothi-y
approved these changes
Nov 7, 2025
mahabaleshwars
approved these changes
Nov 7, 2025
HarithaVattikuti
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances error logging in setup-java to improve troubleshooting and clarity. It adds detailed logs for aggregate network errors, including specific information such as endpoints, ports, and stack traces, making it easier to diagnose and resolve issues effectively. Additionally, it implements a retry mechanism for transient network failures to improve reliability when encountering temporary connectivity issues. Updates workflows to replace usage of
macos-13withmacos-15-intel, ensuring compatibility with newer macOS runner versions.Related issue:
#897, #923
Check list: