Fix #310 The preference_updated signal is now triggered when using the REST API
#311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_updated` signal's.
…ference is updated by the REST API
Author
|
@agateblue Sorry to ask, but did you review this PR ? Don't hesitate to ask for any modification! |
Owner
|
Hi @KrYpTeD974 , I'm very sorry for the delay. Life has been tough lately, I haven't forgotten you and this will be reviewed, but it might take a couple more weeks. Thank you for your patience. |
Author
|
No worries, take the time you need, life can be tough but time generally help a lot. |
agateblue
approved these changes
Jan 10, 2025
Owner
agateblue
left a comment
agateblue
left a comment
There was a problem hiding this comment.
Thank you for your patience. This is looking good, the tests are very clear, let's merge, and I'll push a release today as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been made to the
updatemethod of the PreferenceSerializer to trigger thepreference_updatedsignal.It has been tested for single updates and bulk updates.
I have also added the preference instance to the signal's parameters as it may be needed when you want to retrieve the model bound to a preference, like a workspace, or a user.