Skip to content

chore: Factor out common moe functions in collector #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

chore: Factor out common moe functions in collector #120

merged 1 commit into from
Nov 26, 2025
+208 −390

Conversation

@ilyasher
Copy link
Contributor

@ilyasher ilyasher commented Nov 21, 2025

balanced_logits and power_law_logits_v3 were duplicated in every collect_moe.py file. Factor them out into helper.py

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the chore label Nov 21, 2025
@github-actions github-actions bot requested a review from tianhaox November 21, 2025 23:33
@ilyasher ilyasher force-pushed the dev-isherstyuk-refactor-moe-helper-funcs branch from 05cae8a to f1047dd Compare November 21, 2025 23:35
@ilyasher ilyasher self-assigned this Nov 24, 2025
@ilyasher ilyasher force-pushed the dev-isherstyuk-refactor-moe-helper-funcs branch from f1047dd to 49702f5 Compare November 25, 2025 19:47
@tianhaox tianhaox merged commit 8843aaf into main Nov 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianhaox tianhaox tianhaox approved these changes

@Arsene12358 Arsene12358 Arsene12358 approved these changes

@YijiaZhao YijiaZhao Awaiting requested review from YijiaZhao YijiaZhao is a code owner

@xutizhou xutizhou Awaiting requested review from xutizhou xutizhou is a code owner

@AichenF AichenF Awaiting requested review from AichenF AichenF is a code owner

Assignees

@ilyasher ilyasher

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilyasher @tianhaox @Arsene12358