feat: add exposure service #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new exposure service to track experiment exposures, deprecates the existing assignment service, and introduces a TracksExposure option for evaluations. The exposure service provides similar functionality to the assignment service but with updated naming and improved design patterns.
Key Changes
- Introduced new
ExposureServicewith filtering and tracking capabilities for experiment exposures - Added
TracksExposureoption toEvaluateOptionsfor explicit exposure tracking control - Deprecated
AssignmentService,AssignmentConfig, and related types in favor of the new exposure service
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| exposure.go | Defines the exposure struct and canonicalization logic for deduplication |
| exposure_filter.go | Implements LRU cache-based filtering to prevent duplicate exposure tracking |
| exposure_service.go | Core exposure tracking service that converts exposures to Amplitude events |
| exposure_filter_test.go | Comprehensive test suite for exposure filter functionality |
| exposure_service_test.go | Tests for exposure event generation and tracking logic |
| config.go | Adds ExposureConfig and deprecates AssignmentConfig |
| evaluate_options.go | Introduces TracksExposure option for evaluation control |
| client.go | Integrates exposure service into client initialization and evaluation flow |
| client_test.go | Adds integration test for exposure tracking |
| assignment.go | Adds deprecation documentation |
| assignment_filter.go | Adds deprecation documentation |
| assignment_service.go | Adds deprecation documentation and comments |
| assignment_filter_test.go | Updates import formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📝 Documentation updates detected! New suggestion: Document exposure tracking for Go Experiment SDK local evaluation |
vaibhav-jain-exp
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding exposure service, deprecating assignment service, and adding tracksExposure to evaluate options.
Checklist