Skip to content

Use raise from in plugins #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2025
Merged

Use raise from in plugins #11095

merged 2 commits into from
Nov 12, 2025

Conversation

@felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Nov 11, 2025

SUMMARY

Use raise ... from ... in plugins.

ISSUE TYPE
  • Feature Pull Request
  • Refactoring Pull Request
COMPONENT NAME

various plugins

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-12 Automatically create a backport for the stable-12 branch labels Nov 11, 2025
@ansibullbot
Copy link
Collaborator

ansibullbot commented Nov 11, 2025

cc @Ajpantuso @BongoEADGC6 @Charliekenney23 @InTheCloudDan @LBGarber @None @RevBits @abarbare @aminvakil @azenk @blavoie @conloos @decentral1se @delineaKrehl @displague @eric-belhomme @feldsam @jpmens @keilr @kellyjonbrazil @mattclay @morph027 @nitzmahone @remyleone @rgl @rmcintosh @samdoran @sscheib @tylerezimmerman @vbotka @weisheng-p
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress action action plugin cache cache plugin cloud connection connection plugin feature This issue/PR relates to a feature request filter filter plugin inventory inventory plugin lookup lookup plugin plugins plugin (any type) tests tests unit tests/unit labels Nov 11, 2025
@felixfontein felixfontein marked this pull request as ready for review November 11, 2025 05:14
@ansibullbot ansibullbot removed the WIP Work in progress label Nov 11, 2025
@felixfontein felixfontein mentioned this pull request Nov 11, 2025
Merged
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 11, 2025
@felixfontein felixfontein requested a review from russoz November 11, 2025 05:52
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 11, 2025
russoz
russoz reviewed Nov 11, 2025
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly not for this PR

plugins/filter/from_ini.py
parser.read_file(StringIO(obj))
except Exception as ex:
raise AnsibleFilterError(f"from_ini failed to parse given string: {ex}", orig_exc=ex)
raise AnsibleFilterError(f"from_ini failed to parse given string: {ex}", orig_exc=ex) from ex
Copy link
Collaborator

@russoz russoz Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not investigated the code for that exception but made we could get rid of:

Suggested change
raise AnsibleFilterError(f"from_ini failed to parse given string: {ex}", orig_exc=ex) from ex
raise AnsibleFilterError(f"from_ini failed to parse given string: {ex}") from ex

(possibly in other locations as well)

@felixfontein felixfontein merged commit 2b4333a into ansible-collections:main Nov 12, 2025
134 checks passed
@felixfontein felixfontein deleted the raise-from branch November 12, 2025 19:34
@patchback
Copy link

patchback bot commented Nov 12, 2025 •
edited
Loading

Backport to stable-12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-12/2b4333a033c9669737ad76fde0b464601f9a212a/pr-11095

Backported as #11129

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

felixfontein commented Nov 12, 2025

@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Nov 12, 2025
@felixfontein @patchback
Use raise from in plugins (#11095)
fec9f10 
* Use raise from.

* Add changelog fragment.

(cherry picked from commit 2b4333a)
@patchback patchback bot mentioned this pull request Nov 12, 2025
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 12, 2025
@patchback patchback bot mentioned this pull request Nov 12, 2025
Merged
felixfontein added a commit that referenced this pull request Nov 12, 2025
@patchback @felixfontein
[PR #11095/2b4333a0 backport][stable-12] Use raise from in plugins (#…
cc93dab 
…11129)

Use raise from in plugins (#11095)

* Use raise from.

* Add changelog fragment.

(cherry picked from commit 2b4333a)

Co-authored-by: Felix Fontein <[email protected]>
@felixfontein felixfontein mentioned this pull request Nov 12, 2025
Merged
@patchback patchback bot mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russoz russoz russoz approved these changes

Assignees

No one assigned

Labels

action action plugin backport-12 Automatically create a backport for the stable-12 branch cache cache plugin cloud connection connection plugin feature This issue/PR relates to a feature request filter filter plugin inventory inventory plugin lookup lookup plugin plugins plugin (any type) tests tests unit tests/unit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixfontein @ansibullbot @russoz